search

AzizKpln / Moriarty-Project

This tool gives information about the phone number that you entered.
MIT License
1.49k stars 216 forks source link

Update Moriarty.py #36

Closed gokullan closed 2 years ago

gokullan commented 3 years ago

Xpath updation (in microsoft_mail function)

parulgarg123 commented 3 years ago

Could you please update what the changes are needed and how the changes are tested? @gokullan

gokullan commented 3 years ago

Changes made - Xpath updated in lines 62 and 68 of Moriarty.py (see the 'Files changed' tab for the exact changes) Basically these 2 lines 'generate' (not sure if this is the right word) clicks in the true caller login webpage (https://www.truecaller.com/auth/sign-in): the code on line 62 generates a click on the 'Next' button after you enter your Microsoft mail ID; the code in line 68 generates the 'Sign In' click made after you enter the password. The problem was that the Xpath to these 'Next' and 'Sign In' buttons were not correct (probably because Truecaller might have made some changes to the login page). So I got the correct Xpath of these buttons (using the Inspect option in Chrome) and updated it. Why this change was made - to prevent the Time Out Error bug that arose due to line 62 And with regard to how the changes are tested - I was able to get results after updation of these 2 lines.