search

Azmalent / terra-incognita

A Minecraft worldgen expansion mod
https://modrinth.com/mod/terra-incognita
GNU General Public License v3.0
3 stars 4 forks source link

Crash while attempting to craft the basket #46

Closed Gunner76th closed 3 years ago

Gunner76th commented 3 years ago

https://github.com/Engineers-Life/EL2/issues/131

When attempting to craft the Basket the client freeze for a second or two, then crashes to launcher. If you use the shift method to craft the basket it crafts without issue, but then if you click on the reeds in your inventory it crashes to launcher. crash reports, latest.log file and the debug.log files are all contained in the above link.

Azmalent commented 3 years ago

This is the conflict with newer versions of Quark that was fixed in the new beta. So, closing as duplicate of #40.

Gunner76th commented 3 years ago

I disagree with it being a duplicate of #40 since that issue deals with USING the basket, and this issue deals with CRAFTING the basket, two entirely different functions.

Also, I notice that for 1.7 Beta 2 it says it requires Cunreiform 1.2.4, does this mean it will not work with 1.2.5? If so, perhaps changing the description to state "REQUIRES CUNEIFORM 1.2.4! Or newer" would be more appropriate. I ask this because our modpack is currently running Cuneiform 1.2.5.

And I am guessing you had up a 1.7 version prior to Beta 1 or Beta 2, because the version we are using is image image

Hopefully updating that to Beta 2 resolves the issue, provided that using Cuneiform 1.2.5 doesnt cause issues.

Azmalent commented 3 years ago

I disagree with it being a duplicate of #40 since that issue deals with USING the basket, and this issue deals with CRAFTING the basket, two entirely different functions.

The crash was caused by my drop-in implementation which broke when AutoRegLib changed the relevant interface. It happened when you hovered your mouse over the item, regardless of what you were trying to do with it.

Also, I notice that for 1.7 Beta 2 it says it requires Cunreiform 1.2.4, does this mean it will not work with 1.2.5?

Yeah, Cuneiform 1.2.5 is backwards compatible with 1.2.4, the only difference is that the tweaks were removed.

And I am guessing you had up a 1.7 version prior to Beta 1 or Beta 2

My bad! The actual file wasn't initially labelled as beta, I only renamed it on Curseforge after uploading the second beta. Both betas are labelled as 1.7 in the mods.toml file, because I forgot to label them properly. The new beta has a -BETA2 suffix on Curseforge.

Gunner76th commented 3 years ago

Thanks for the update. Ill pass it along.