Azmalent / terra-incognita

A Minecraft worldgen expansion mod
https://modrinth.com/mod/terra-incognita
GNU General Public License v3.0
3 stars 4 forks source link

[1.18.2] Crash on world creation or exploring new chunks from old worlds(pre 2.0) #75

Closed dr3ams closed 7 months ago

dr3ams commented 1 year ago

java.lang.IllegalStateException: Feature order cycle found

Tried exploring new chunks in old world(from 2.0 BETA) got crash mentioning Blueprint library: https://pastebin.com/xgJy8pkE

deleted Blueprint library and all related mods to it and then tried to generate new world: https://pastebin.com/jHVrapUf

terraincognita-1.18.2-2.0.1 cuneiform-1.18.2-1.3.4 TerraBlender-forge-1.18.2-1.2.0.126

Is 2.0 update compatible with old worlds, created in BETA?

Azmalent commented 1 year ago

The 2.0 release should be fully compatible, except for the fact that sedge got renamed back to swamp reeds, so it will disappear from existing worlds. I didn't bother with remapping IDs because reeds have new blockstates, so they would break in old worlds regardless.

This error is really weird, after a quick check I don't see anything that could be causing it. Could you please install Cyanide and post the new logs?

dr3ams commented 1 year ago

Weird, I thought I was going insane when it suddenly fixed itself but that was because I added Cyanide.

It crashes without Cyanide and works with Cyanide.

Anyway, here's the latest.log of world creation: https://gist.github.com/dr3ams/2ffa5e09db2b7e0ba86e7164185f58fd

Azmalent commented 1 year ago

This is strange. Feature order cycles are hard to debug because they are random and inconsistent.

Basically, it's what happens when biome A generates flowers first and then grass (for example), while biome B does it in reverse order. So when they are next to each other and the game generates features on the biome border, it doesn't know what to generate first, so it crashes.