Azn9 / JetBrains-Discord-Integration

Discord rich presence integration for all JetBrains IDEs
Apache License 2.0
132 stars 10 forks source link

Incorrect language icon displayed on Discord #41

Closed npxtune closed 9 months ago

npxtune commented 9 months ago

What is the issue?

Selecting the Flat or Atom language icons results in the usage of the Material one instead. e.g:

Expected outcome:

Screenshot 2023-11-17 at 14 17 11

What actually happens:

Screenshot 2023-11-17 at 14 17 19 (This is the icon for the Material Language icon themes)


A fix would be appreciated :)

Cheers

Azn9 commented 9 months ago

Yep for CLion Nova, Writerside, Rust rover and Aqua there are only the two themes. I can fix this easily now that AlmightyAlpaca updated the original plugin.

Azn9 commented 9 months ago

Resolved by https://github.com/Azn9/JetBrains-Discord-Integration/commit/8dab8da05778aefc37cf0b7fb4aa4da541cecd24

npxtune commented 9 months ago

Seems to work now, however I have to manually change the icon theme in the project's discord xml file because the editor does not override / update the file's value.

Azn9 commented 9 months ago

You can set the theme to "default" in the project options ;)

npxtune commented 9 months ago

yup, now switching themes in the editor works 👍 i previously deleted the discord.xml and it did not set reset itself to 'default', is that intended to happen (eg. new projects as well)? Also, you might wanna change the theme preview in the "file" tab "^^

Screenshot 2023-12-03 at 15 11 12

Azn9 commented 9 months ago

Due to how settings are done, setting "default" as default causes issues :( for now it copies the current application theme, but I'll look into fixing that.

Also thanks for noticing that, I missed it 😥