AznamirWoW / PallyPower

The official repository of PallyPower for retail version of World of Warcraft Classic/TBC
Other
6 stars 7 forks source link

PP does not recognize timer for ZG 5-piece timer #20

Open lvangh opened 1 year ago

lvangh commented 1 year ago

The Freethinker's 5 piece gives 10% to buff duration, making greater blessings 17 minutes, but the PP frames do not recognize the buff. I don't know if the spell ID is different - maybe a check for gear slots when the blessing is cast?

TY image

AznamirWoW commented 1 year ago

I have no way of reproducing this. You can try checking the buff on your character by using /dump UnitBuff("player", x) where x is from 1 to whatever until you find it.

See if it results in different outputs with and without the set.

lvangh commented 1 year ago

Here is the 5pc version (17m) image

Here is the standard 15m version image

lvangh commented 1 year ago

it looks like the time is 990 vs 900 so maybe check if the timer is greater than 900 set a flag for 5 piece and adjust the timers in PP buff list?

AznamirWoW commented 1 year ago

So what's the issue? PallyPower does not see the buff as active? or does it show a wrong expiration time?

With the same spell ID it should not matter how long the buff lasts. The buff duration is only used for calculating the recast penalty. This function check for the buff present:

/dump PallyPower:IsBuffActive("Blessing of Wisdom", "Greater Blessing of Wisdom", "player")

lvangh commented 1 year ago

Pallypower shows the wrong expired time.

On Tue, Aug 29, 2023, 3:12 PM AznamirWoW @.***> wrote:

So what's the issue? PallyPower does not see the buff as active? or does it show a wrong expiration time?

With the same spell ID it should not matter how long the buff lasts. The buff duration is only used for calculating the recast penalty. This function check for the buff present:

/dump PallyPower:IsBuffActive("Blessing of Wisdom", "Greater Blessing of Wisdom", "player")

— Reply to this email directly, view it on GitHub https://github.com/AznamirWoW/PallyPower/issues/20#issuecomment-1698213685, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEWHE4H6WJVJTI33SEARTQDXXZSLNANCNFSM6AAAAAA4AXVG5Y . You are receiving this because you authored the thread.Message ID: @.***>

AznamirWoW commented 1 year ago

Could you clarify (screenshot) what exactly wrong with the displayed time?

I just don't see how that is possible. The displayed time is the 1st value returned by IsBuffActive.

image

lvangh commented 1 year ago

it's really odd because it doesn't seem to be consistent. Here is a screenshot from my raid on Sunday showing my buff timer at 16m and PP showing 14m. But just now while I tried it is showing the correct time - but the only difference here is that I'm not in a raid right now - just solo.

image

AznamirWoW commented 1 year ago

Try the same command in the raid, just change the blessing name

/dump PallyPower:IsBuffActive("Blessing of Wisdom", "Greater Blessing of Wisdom", "player")

lvangh commented 1 year ago

Sorry to leave you hanging - haven't forgot about this just haven't had time to play - next raid I will post ASAP.

lvangh commented 10 months ago

OK finally got back to playing a bit, and found another example (but not yet in a raid.)

I tested in a party - buff timer shows 17 minutes for ME, but not the other person in the party. Only 15m.

image

I get that it might just look like I staggered the buffs and might not help that much but what I'll do is record this in OBS and post something soon.

Sorry for the delay - hope this helps somewhat until then. TY

lvangh commented 10 months ago

So weird, today in a 40 raid it worked as intended and showed the correct times. I wonder if a backend spell ID was corrected? Keep this open for now until I can test more

AznamirWoW commented 10 months ago

So weird, today in a 40 raid it worked as intended and showed the correct times. I wonder if a backend spell ID was corrected? Keep this open for now until I can test more

I don't see any different spell ID in the database for the blessings, I think the game just sets the expiration time with some extra time.

lvangh commented 7 months ago

Just keeping in touch with this - will try to test soon on Era and hopefully have an OBS recording. I haven't been able to play lately. ty