search

Azolo / websockex

An Elixir Websocket Client
MIT License
520 stars 100 forks source link

Telemetry Events? #99

Closed pedro-gutierrez closed 3 years ago

pedro-gutierrez commented 3 years ago

Hello,

This is a question or a feature request.

I was wondering whether it would be a good idea to add telemetry to this library?

Initially something simple such as:

Happy to try to submit a PR if such a feature would be welcome.

Thank you! :)

Azolo commented 3 years ago

Yeah, that would be cool.

I think the hardest part would be testing telemetry events.

pedro-gutierrez commented 3 years ago

Hey thank you. I gave it a try, and it seems to be working okay, but unfortunately the :telemetry application only compiles on OTP 21 or later, so the CI is failing for older releases is still passing, but the telemetry events will only be fired if the websockex application is compiled with OTP 21 or later.