Azordev / dasher-user

ONLINE ACCESS SYSTEM FOR CUSTOMER AND CONSUMER MONITORING.
https://dev--azordev-dasher-user.netlify.app/
Apache License 2.0
2 stars 4 forks source link

Review better ways to handle the package #152

Closed heliomar-pena closed 2 years ago

heliomar-pena commented 2 years ago

Actually we handle the package by the package ID passing it through the URL. The question is, exists better ways to handle the package ID?

The options are:

I would like to know your opinion team

Israel-Laguan commented 2 years ago

@denisosuna do you think is easy to use package-code, or maybe we stick with using local session/storage?

e-azocar commented 2 years ago

I think the second option is the best to do this. But I wait for the opinions of others

denisosuna commented 2 years ago

The refactor to use the name of the package is simple and showing the code of the package would be more descriptive for the user, on the second option we would need to use helmet to show the name of the package in the title, I think the third option will be the easier to apply so no refactor is needed.

Another option is to pass both Id and package code as parameters in URL.

Israel-Laguan commented 2 years ago

The Third option is OK for me, any objections to deciding on this one @Azordev/dasher ?

e-azocar commented 2 years ago

The third option is ok. But, why we need save the info in localstorage?

heliomar-pena commented 2 years ago

The third option is ok for me.

e-azocar commented 2 years ago

So, the third option

Israel-Laguan commented 2 years ago

@Katsu08 please add a new issue with the decision we made