Azordev / dasher-user

ONLINE ACCESS SYSTEM FOR CUSTOMER AND CONSUMER MONITORING.
https://dev--azordev-dasher-user.netlify.app/
Apache License 2.0
2 stars 4 forks source link

Fix ts-check errors in src/components/BackButton.js #161

Closed heliomar-pena closed 2 years ago

heliomar-pena commented 2 years ago

Explication

Please remove this ts-nocheck and solve the next problems

https://github.com/Azordev/dasher-user/blob/dccbce3b5b6ea8af657388eec98dfaac7b201ff9/src/components/BackButton/BackButton.js#L1

Screenshots

imagen imagen

Checklist

This issue can be closed when the following tasks are complete:

References

https://github.com/Azordev/dasher-user/pull/154#discussion_r751254342

Israel-Laguan commented 2 years ago

Text should be passed as children, directly inside

e-azocar commented 2 years ago

The problem is that prop. Directly passing as children works correctly

heliomar-pena commented 2 years ago

Thanks for the comments, i have update the issue @Israel-Laguan @e-azocar

e-azocar commented 2 years ago

I just needed this line image

Israel-Laguan commented 2 years ago

I just needed this line image

This can be done in the cases we don't know types, is that ok for you @e-azocar ?

e-azocar commented 2 years ago

I just needed this line image

This can be done in the cases we don't know types, is that ok for you @e-azocar ?

I think that we can use "any" as a type

Israel-Laguan commented 2 years ago

I think that we can use "any" as a type

if its an object is ok with me, but if the type is easy to infer maybe adding the type is better