Azoy / Sword

Discord library for Swift
https://azoy.github.io/Sword
MIT License
179 stars 52 forks source link

use `.git` on engine to prevent limiting other vapor dependencies #27

Closed loganwright closed 7 years ago

loganwright commented 7 years ago

There is a bug in SPM where two dependencies that are the same need to be case identical. In server side ecosystem, it's common to use the name as resolved w/ casings and append .git onto the end.

At the moment, users are unable to use this alongside other packages that depend on Vapor or Engine.

I only changed Engine for now, but if you'd like to opt-in to the .git on all of your dependencies, I think in the long run it'd be beneficial for adoption 👍

Let me know if there's anything else I can do.

Azoy commented 7 years ago

Would it be possible to merge this with the dev branch?

loganwright commented 7 years ago

@Azoy updated