Azoy / Sword

Discord library for Swift
https://azoy.github.io/Sword
MIT License
179 stars 52 forks source link

Implement transport compression #56

Closed omochi closed 5 years ago

omochi commented 5 years ago

I implemented transport compression. I keep code difference small as much as I can. I split changes to some commits so that it is easy to review.

I explain detail.

~- 0206648: Change nio-websocket-client to my fork.~ ~This commit is submitted as this PR https://github.com/vapor/nio-websocket-client/pull/4~ ~It solves problems them.~ ~- WebSocket binary frame support~ ~- Fix bug that WebSocket stream lost sometimes.~

Azoy commented 5 years ago

I'd be willing to take b0f6909, 8238f94, b0923b4, and 8c1333e. I'd prefer to stay depending on vapor's repo, I have some changes to request that I have locally that I want to push soon, and I'd really like to fix zlib if you don't mind (I might ditch it in favor of something else maybe). It would be beneficial if your changes got landed on vapor's repo however.

omochi commented 5 years ago

Thanks to check. I rebased PR to pick these 4 commits up and dropped others.

I will open issues about dropped topics to tell that you recognize these problems for other library users. When your changes to be shared, I close them.