static mul bench is measuring in-place addition - Githubissues

AztecProtocol / aztec-2.0

C++ elliptic curve library

134 stars 37 forks source link

static mul bench is measuring in-place addition #35

Closed mratsim closed 4 years ago

mratsim commented 4 years ago

The static mul bench seems to be measuring in-place addition:

https://github.com/AztecProtocol/barretenberg/blob/d815655681e8e42db3e716afdb60d8afb2e8f279/barretenberg/src/aztec/ecc/curves/bn254/fr.bench.cpp#L221-L228

https://github.com/AztecProtocol/barretenberg/blob/d815655681e8e42db3e716afdb60d8afb2e8f279/barretenberg/src/aztec/ecc/curves/bn254/fr.bench.cpp#L291-L298

Is that intended? (As I suppose it's for multiplication with compile-time operand)

zac-williamson commented 4 years ago

Thanks for spotting this @mratsim . A fix has been pushed to master