AztecProtocol / aztec-packages

Apache License 2.0
203 stars 235 forks source link

Remove duplication of Uniswap e2e example #2072

Closed spalladino closed 1 year ago

spalladino commented 1 year ago

The code for the uniswap trade e2e example is replicated three times in our codebase:

We should have a single copy of it, and either import or symlink it where needed. Otherwise, every change to that test needs to be done on 3 exact copies of the same code.

rahul-kothari commented 1 year ago

I am deleting sandbox-example

What is the best course of action for merging the canary with end-to-end?

ludamad commented 1 year ago

We should probably have the entire end-to-end suite testable in a canary-like fashion against the sandbox and NPM packages?

spypsy commented 1 year ago

Closing this as duplicate of #2303

spalladino commented 1 year ago

Gotta love the irony of closing an issue about duplicate code as a duplicate