AztecProtocol / aztec-packages

Apache License 2.0
212 stars 246 forks source link

Remove `using namespace` in barretenberg header files #2216

Open zac-williamson opened 1 year ago

zac-williamson commented 1 year ago

program_settings.hpp includes header files that added "using namespace proof_system" and "using namespace barretenberg" declarations. This effects downstream code that relies on these using declarations. This is a big code smell (should really not have using declarations in header files!), however fixing it requires changes in a LOT of files.

We likely have using namespace declarations in header files elsewhere in the codebase that need to be removed.

maramihali commented 1 year ago

this PR https://github.com/AztecProtocol/aztec-packages/pull/2125 removes them

maramihali commented 1 year ago

also it would be better if these issues lived in bberg

codygunton commented 1 year ago

As of 2023-11-21 there are 52 instances 😦