search

AztecProtocol / aztec-packages

Apache License 2.0
181 stars 184 forks source link

chore: remove stray files #7158

Closed fcarreiro closed 3 months ago

fcarreiro commented 3 months ago

Remove files introduced in https://github.com/AztecProtocol/aztec-packages/pull/7078.

fcarreiro commented 3 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite Graphite

AztecBot commented 3 months ago

Benchmark results

Metrics with a significant change:

Detailed results All benchmarks are run on txs on the `Benchmarking` contract on the repository. Each tx consists of a batch call to `create_note` and `increment_balance`, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write. This benchmark source data is available in JSON format on S3 [here](https://aztec-ci-artifacts.s3.us-east-2.amazonaws.com/benchmarks-v1/pulls/7158.json). ### Proof generation Each column represents the number of threads used in proof generation. | Metric | 1 threads | 4 threads | 16 threads | 32 threads | 64 threads | | - | - | - | - | - | - | proof_construction_time_sha256_30_ms | :warning: 15,465 (**+34%**) | 3,054 (-2%) | :warning: 1,378 (**-26%**) | 1,416 (-12%) | 1,450 (-6%) | proof_construction_time_sha256_100_ms | 50,468 (+11%) | 13,234 (+9%) | 5,673 | 5,530 (-1%) | 5,517 | proof_construction_time_poseidon_hash_ms | 77.0 (-1%) | 34.0 | 34.0 | 57.0 | 87.0 | proof_construction_time_poseidon_hash_30_ms | 1,721 (+12%) | 417 (-1%) | 202 | 224 (-1%) | 266 | proof_construction_time_poseidon_hash_100_ms | 5,737 (-1%) | 1,568 (-2%) | 726 | 773 (+2%) | 801 (-1%) | ### L2 block published to L1 Each column represents the number of txs on an L2 block published to L1. | Metric | 4 txs | 8 txs | 16 txs | | - | - | - | - | l1_rollup_calldata_size_in_bytes | 1,412 | 1,412 | 1,412 | l1_rollup_calldata_gas | 9,452 | 9,464 | 9,440 | l1_rollup_execution_gas | 610,273 | 610,285 | 610,261 | l2_block_processing_time_in_ms | 746 (-1%) | 1,408 (+1%) | 2,678 | l2_block_building_time_in_ms | 25,690 (+2%) | 50,820 | 101,654 (+2%) | l2_block_rollup_simulation_time_in_ms | 25,594 (+2%) | 50,522 | 101,302 (+2%) | l2_block_public_tx_process_time_in_ms | 21,953 (+2%) | 46,773 | 97,549 (+2%) | ### L2 chain processing Each column represents the number of blocks on the L2 chain where each block has 8 txs. | Metric | 3 blocks | 5 blocks | | - | - | - | node_history_sync_time_in_ms | 6,970 (+1%) | 9,838 (+1%) | node_database_size_in_bytes | 12,152,912 | 16,109,648 | pxe_database_size_in_bytes | 16,254 | 26,813 | ### Circuits stats Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks. | Circuit | simulation_time_in_ms | witness_generation_time_in_ms | proving_time_in_ms | input_size_in_bytes | output_size_in_bytes | proof_size_in_bytes | num_public_inputs | size_in_gates | | - | - | - | - | - | - | - | - | - | private-kernel-init | 131 (+2%) | 502 (+6%) | 12,297 (-5%) | 20,634 | 67,190 | 92,352 | 2,819 | 524,288 | private-kernel-inner | 397 (+1%) | 1,043 (+10%) | 44,845 (-12%) | 94,902 | 67,190 | 92,352 | 2,819 | 2,097,152 | private-kernel-tail | 372 (+1%) | 1,929 (+5%) | 46,111 (-12%) | 99,121 | 71,733 | 14,912 | 399 | 2,097,152 | base-parity | 6.30 (+1%) | 1,938 (+1%) | 2,564 (-8%) | 128 | 64.0 | 2,208 | 2.00 | 131,072 | root-parity | 49.4 (+1%) | 48.4 (-24%) | :warning: 33,633 (**-16%**) | 27,100 | 64.0 | 2,720 | 18.0 | 2,097,152 | base-rollup | 7,953 (+1%) | 4,400 (+1%) | 73,003 (-14%) | 170,330 | 756 | 3,648 | 47.0 | 4,194,304 | root-rollup | 112 (+2%) | 67.0 (-16%) | 19,429 (-12%) | 25,309 | 620 | 3,456 | 41.0 | 1,048,576 | public-kernel-setup | 727 | 3,168 (-3%) | 38,818 (-15%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | public-kernel-app-logic | 614 (+1%) | 4,183 (-2%) | 40,285 (-15%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | public-kernel-tail | 1,422 (+1%) | 30,191 (-14%) | :warning: 165,022 (**-16%**) | 511,910 | 10,014 | 14,912 | 399 | 8,388,608 | private-kernel-reset-small | 598 (+1%) | 2,092 (+6%) | 40,986 (-15%) | 123,313 | 67,190 | 92,352 | 2,819 | 2,097,152 | public-kernel-teardown | 624 | 4,159 (-1%) | :warning: 40,373 (**-16%**) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | merge-rollup | 28.8 (+1%) | N/A | N/A | 16,542 | 756 | N/A | N/A | N/A | private-kernel-tail-to-public | N/A | 7,278 (+2%) | :warning: 85,135 (**-16%**) | N/A | N/A | 125,344 | 3,850 | 4,194,304 | Stats on running time collected for app circuits | Function | input_size_in_bytes | output_size_in_bytes | witness_generation_time_in_ms | proof_size_in_bytes | proving_time_in_ms | size_in_gates | num_public_inputs | | - | - | - | - | - | - | - | - | ContractClassRegisterer:register | 1,344 | 9,944 | 407 (+2%) | N/A | N/A | N/A | N/A | ContractInstanceDeployer:deploy | 1,408 | 9,944 | 40.8 (+2%) | N/A | N/A | N/A | N/A | MultiCallEntrypoint:entrypoint | 1,920 | 9,944 | 1,809 (+2%) | N/A | N/A | N/A | N/A | GasToken:deploy | 1,376 | 9,944 | 984 (+2%) | N/A | N/A | N/A | N/A | SchnorrAccount:constructor | 1,312 | 9,944 | 1,465 (+3%) | N/A | N/A | N/A | N/A | SchnorrAccount:entrypoint | 2,304 | 9,944 | 2,841 (+1%) | 16,768 | 51,295 (-9%) | 2,097,152 | 457 | Token:privately_mint_private_note | 1,280 | 9,944 | 1,754 (+5%) | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_public | 1,344 | 9,944 | 374 (+5%) | 16,768 | 10,457 (-9%) | 524,288 | 457 | Token:transfer | 1,312 | 9,944 | 4,515 (+2%) | 16,768 | 41,832 (-15%) | 2,097,152 | 457 | AuthRegistry:set_authorized (avm) | 21,043 | N/A | N/A | 87,200 | :warning: 1,652 (**+20%**) | N/A | N/A | FPC:prepare_fee (avm) | 28,841 | N/A | N/A | 88,032 | :warning: 4,886 (**-19%**) | N/A | N/A | Token:transfer_public (avm) | 44,971 | N/A | N/A | 87,865 | 4,157 (-13%) | N/A | N/A | AuthRegistry:consume (avm) | 34,973 | N/A | N/A | 87,616 | 2,898 (-4%) | N/A | N/A | FPC:pay_refund (avm) | 33,573 | N/A | N/A | 88,448 | :warning: 8,971 (**-19%**) | N/A | N/A | Benchmarking:create_note | 1,344 | 9,944 | 1,391 (-1%) | N/A | N/A | N/A | N/A | SchnorrAccount:verify_private_authwit | 1,280 | 9,944 | 86.4 (+18%) | N/A | N/A | N/A | N/A | Token:unshield | 1,376 | 9,944 | 3,660 (+2%) | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_private | 1,376 | 9,944 | 4,673 (+3%) | N/A | N/A | N/A | N/A | ### AVM Simulation Time to simulate various public functions in the AVM. | Function | time_ms | bytecode_size_in_bytes | | - | - | - | GasToken:_increase_public_balance | 68.0 (-3%) | 13,873 | GasToken:set_portal | 16.7 (+4%) | 3,495 | Token:constructor | 95.4 (+2%) | 24,207 | FPC:constructor | 62.5 (+2%) | 13,893 | GasToken:mint_public | 53.5 (+2%) | 10,241 | Token:mint_public | :warning: 69.3 (**-89%**) | 19,216 | Token:assert_minter_and_mint | :warning: 226 (**+200%**) | 13,034 | AuthRegistry:set_authorized | 32.6 (+2%) | 7,869 | FPC:prepare_fee | 145 (-19%) | 15,187 | Token:transfer_public | 35.7 (+16%) | 31,425 | FPC:pay_refund | 139 (+10%) | 20,080 | Benchmarking:increment_balance | 2,710 (+2%) | 15,465 | Token:_increase_public_balance | 55.8 (-8%) | 15,089 | FPC:pay_refund_with_shielded_rebate | 147 (-6%) | 21,167 | ### Public DB Access Time to access various public DBs. | Function | time_ms | | - | - | get-nullifier-index | 0.174 (-3%) | ### Tree insertion stats The duration to insert a fixed batch of leaves into each tree type. | Metric | 1 leaves | 16 leaves | 64 leaves | 128 leaves | 256 leaves | 512 leaves | 1024 leaves | | - | - | - | - | - | - | - | - | batch_insert_into_append_only_tree_16_depth_ms | 10.3 (+1%) | 16.8 (+1%) | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_count | 16.8 | 31.7 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_ms | 0.599 (+1%) | 0.517 (+1%) | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_32_depth_ms | N/A | N/A | 49.0 (+1%) | 75.6 | 130 (-1%) | 243 | 468 (-1%) | batch_insert_into_append_only_tree_32_depth_hash_count | N/A | N/A | 95.9 | 159 | 287 | 543 | 1,055 | batch_insert_into_append_only_tree_32_depth_hash_ms | N/A | N/A | 0.501 (+1%) | 0.464 | 0.448 (-1%) | 0.442 | 0.437 (-1%) | batch_insert_into_indexed_tree_20_depth_ms | N/A | N/A | 59.6 | 111 | 181 (-1%) | 351 (+1%) | 688 (-1%) | batch_insert_into_indexed_tree_20_depth_hash_count | N/A | N/A | 109 | 207 | 355 | 691 | 1,363 | batch_insert_into_indexed_tree_20_depth_hash_ms | N/A | N/A | 0.504 | 0.498 | 0.476 (-1%) | 0.475 (+1%) | 0.473 (-1%) | batch_insert_into_indexed_tree_40_depth_ms | N/A | N/A | 72.7 (+1%) | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_count | N/A | N/A | 133 | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_ms | N/A | N/A | 0.518 (+1%) | N/A | N/A | N/A | N/A | ### Miscellaneous Transaction sizes based on how many contract classes are registered in the tx. | Metric | 0 registered classes | 1 registered classes | | - | - | - | tx_size_in_bytes | 85,672 | 670,983 | Transaction size based on fee payment method | Metric | | | - | |