search

AztecProtocol / aztec-packages

Apache License 2.0
155 stars 157 forks source link

feat(Event_Logs): Update unencrypted emit in public #7162

Closed LHerskind closed 4 days ago

LHerskind commented 1 week ago

In PublicContext the emit_unencrypted_log_with_selector and emit_unencrypted_log. I'm not really sure "why" it actually have event id as part of what it is emitting. In my mind it would be useful to just have emit_raw_log in there, and then use a similar .emit function on events etc to deal with how it is actually constructing the message that is broadcast. Not clear to me why we are enshrining the event id in there.

Likely useful to hear what @fcarreiro says on this 👀.

fcarreiro commented 1 week ago

I think from our PoV we are (more than) happy to just remove the event selector from the opcode (and context) if it's not needed as something enshrined. It's currently implemented that way because it was in the (vm) spec. @dbanks12 wdyt?

sklppy88 commented 4 days ago

Closed with #7232 and #7192. Have created #7198 for cleanup and will tackle next.

Thanks @fcarreiro !