AztecProtocol / aztec-packages

Apache License 2.0
155 stars 157 forks source link

feat(Keys): Populate recipient in outgoing #7177

Open LHerskind opened 1 week ago

LHerskind commented 1 week ago

When sending an outgoing log, we are populating it with a recipient, however, these are currently just set to be 0.

In the payload.nr we for example have (twice)

// @todo This value needs to be populated!
let recipient = AztecAddress::from_field(0);

Instead we should be taking an input here. I think in most cases we can use the same address as the one we are using for incoming viewing as well. It might not necessarily be the case though, so it is not fully clear to me if we want to have it is as an extra argument or just populate it with the same value.