search

AztecProtocol / aztec-packages

Apache License 2.0
181 stars 184 forks source link

fix(avm): update codegen #7178

Closed IlyasRidhuan closed 3 months ago

IlyasRidhuan commented 3 months ago

Please read contributing guidelines and remove this line.

IlyasRidhuan commented 3 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @IlyasRidhuan and the rest of your teammates on Graphite Graphite

AztecBot commented 3 months ago

Benchmark results

Metrics with a significant change:

Detailed results All benchmarks are run on txs on the `Benchmarking` contract on the repository. Each tx consists of a batch call to `create_note` and `increment_balance`, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write. This benchmark source data is available in JSON format on S3 [here](https://aztec-ci-artifacts.s3.us-east-2.amazonaws.com/benchmarks-v1/pulls/7178.json). ### Proof generation Each column represents the number of threads used in proof generation. | Metric | 1 threads | 4 threads | 16 threads | 32 threads | 64 threads | | - | - | - | - | - | - | proof_construction_time_sha256_30_ms | 11,683 | 3,150 (-2%) | :warning: 1,491 (**-16%**) | 1,631 (-1%) | 1,468 (+1%) | proof_construction_time_sha256_100_ms | 44,861 | 11,755 | 5,544 (+2%) | 5,416 | 5,371 | proof_construction_time_poseidon_hash_ms | 78.0 | 34.0 | 34.0 | 57.0 (-2%) | 88.0 (-1%) | proof_construction_time_poseidon_hash_30_ms | 1,512 | 415 | 199 | 223 (-2%) | 266 | proof_construction_time_poseidon_hash_100_ms | 5,734 | 1,573 (-1%) | 723 | 769 | 793 | ### L2 block published to L1 Each column represents the number of txs on an L2 block published to L1. | Metric | 4 txs | 8 txs | 16 txs | | - | - | - | - | l1_rollup_calldata_size_in_bytes | 1,412 | 1,412 | 1,412 | l1_rollup_calldata_gas | 9,476 | 9,466 | 9,464 | l1_rollup_execution_gas | 610,297 | 610,287 | 610,285 | l2_block_processing_time_in_ms | 757 (+1%) | 1,421 (+1%) | 2,698 | l2_block_building_time_in_ms | 25,673 | 51,022 | 101,088 | l2_block_rollup_simulation_time_in_ms | 25,576 | 50,718 | 100,730 | l2_block_public_tx_process_time_in_ms | 21,983 | 46,948 | 97,002 | ### L2 chain processing Each column represents the number of blocks on the L2 chain where each block has 8 txs. | Metric | 3 blocks | 5 blocks | | - | - | - | node_history_sync_time_in_ms | 7,091 (+1%) | 9,961 (+1%) | node_database_size_in_bytes | 12,128,336 | 16,109,648 | pxe_database_size_in_bytes | 16,254 | 26,813 | ### Circuits stats Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks. | Circuit | simulation_time_in_ms | witness_generation_time_in_ms | proving_time_in_ms | input_size_in_bytes | output_size_in_bytes | proof_size_in_bytes | num_public_inputs | size_in_gates | | - | - | - | - | - | - | - | - | - | private-kernel-init | 130 (+1%) | 473 (+1%) | 13,556 | 20,634 | 67,190 | 92,352 | 2,819 | 524,288 | private-kernel-inner | 394 (+1%) | 1,041 (+8%) | 50,575 (-1%) | 94,902 | 67,190 | 92,352 | 2,819 | 2,097,152 | private-kernel-tail | 372 | 1,831 (-2%) | 53,740 | 99,121 | 71,733 | 14,912 | 399 | 2,097,152 | base-parity | 6.22 (-1%) | 1,878 (-4%) | 2,760 (+1%) | 128 | 64.0 | 2,208 | 2.00 | 131,072 | root-parity | 49.1 | 77.2 (+1%) | 42,895 (+6%) | 27,100 | 64.0 | 2,720 | 18.0 | 2,097,152 | base-rollup | 7,902 (-1%) | 4,948 | 86,539 (-1%) | 170,330 | 756 | 3,648 | 47.0 | 4,194,304 | root-rollup | 110 (+1%) | 87.4 (-3%) | 23,341 (+3%) | 25,309 | 620 | 3,456 | 41.0 | 1,048,576 | public-kernel-setup | 718 (+1%) | 3,767 | 45,959 (+1%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | public-kernel-app-logic | 613 | 4,741 (-1%) | 46,994 (-1%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | public-kernel-tail | 1,412 | 37,941 (+8%) | 195,692 (+2%) | 511,910 | 10,014 | 14,912 | 399 | 8,388,608 | private-kernel-reset-small | 595 | 2,217 (+9%) | 46,243 (-1%) | 123,313 | 67,190 | 92,352 | 2,819 | 2,097,152 | public-kernel-teardown | 615 | 4,843 (+3%) | 46,778 (-1%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | merge-rollup | 28.9 | N/A | N/A | 16,542 | 756 | N/A | N/A | N/A | private-kernel-tail-to-public | N/A | 6,829 (-2%) | 99,264 (-3%) | N/A | N/A | 125,344 | 3,850 | 4,194,304 | Stats on running time collected for app circuits | Function | input_size_in_bytes | output_size_in_bytes | witness_generation_time_in_ms | proof_size_in_bytes | proving_time_in_ms | size_in_gates | num_public_inputs | | - | - | - | - | - | - | - | - | ContractClassRegisterer:register | 1,344 | 9,944 | 426 (+1%) | N/A | N/A | N/A | N/A | ContractInstanceDeployer:deploy | 1,408 | 9,944 | 39.7 (+1%) | N/A | N/A | N/A | N/A | MultiCallEntrypoint:entrypoint | 1,920 | 9,944 | 1,788 (+1%) | N/A | N/A | N/A | N/A | GasToken:deploy | 1,376 | 9,944 | 985 (+2%) | N/A | N/A | N/A | N/A | SchnorrAccount:constructor | 1,312 | 9,944 | 1,428 | N/A | N/A | N/A | N/A | SchnorrAccount:entrypoint | 2,304 | 9,944 | 2,827 | 16,768 | 56,065 (+1%) | 2,097,152 | 457 | Token:privately_mint_private_note | 1,280 | 9,944 | 1,668 (+2%) | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_public | 1,344 | 9,944 | 362 (+5%) | 16,768 | 11,412 (+2%) | 524,288 | 457 | Token:transfer | 1,312 | 9,944 | 4,425 | 16,768 | 46,053 (-1%) | 2,097,152 | 457 | AuthRegistry:set_authorized (avm) | 21,043 | N/A | N/A | 87,200 | 1,382 (+2%) | N/A | N/A | FPC:prepare_fee (avm) | 28,841 | N/A | N/A | 88,032 | 5,981 (+2%) | N/A | N/A | Token:transfer_public (avm) | 44,971 | N/A | N/A | 87,865 | 4,915 (+2%) | N/A | N/A | AuthRegistry:consume (avm) | 34,973 | N/A | N/A | 87,616 | 3,305 (+10%) | N/A | N/A | FPC:pay_refund (avm) | 33,573 | N/A | N/A | 88,448 | 11,577 (+2%) | N/A | N/A | Benchmarking:create_note | 1,344 | 9,944 | 1,410 (+1%) | N/A | N/A | N/A | N/A | SchnorrAccount:verify_private_authwit | 1,280 | 9,944 | 73.3 | N/A | N/A | N/A | N/A | Token:unshield | 1,376 | 9,944 | 3,594 (+1%) | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_private | 1,376 | 9,944 | 4,528 (-2%) | N/A | N/A | N/A | N/A | ### AVM Simulation Time to simulate various public functions in the AVM. | Function | time_ms | bytecode_size_in_bytes | | - | - | - | GasToken:_increase_public_balance | 71.7 (+10%) | 13,873 | GasToken:set_portal | 15.5 (-16%) | 3,495 | Token:constructor | 97.5 (+6%) | 24,207 | FPC:constructor | 63.6 (+1%) | 13,893 | GasToken:mint_public | 52.6 (+3%) | 10,241 | Token:mint_public | 603 | 19,216 | Token:assert_minter_and_mint | 72.4 (-2%) | 13,034 | AuthRegistry:set_authorized | 31.7 (+4%) | 7,869 | FPC:prepare_fee | 145 (-5%) | 15,187 | Token:transfer_public | :warning: 34.4 (**-34%**) | 31,425 | FPC:pay_refund | 152 (+4%) | 20,080 | Benchmarking:increment_balance | 2,688 (-1%) | 15,465 | Token:_increase_public_balance | 55.6 (-1%) | 15,089 | FPC:pay_refund_with_shielded_rebate | 146 (-1%) | 21,167 | ### Public DB Access Time to access various public DBs. | Function | time_ms | | - | - | get-nullifier-index | 0.159 (+3%) | ### Tree insertion stats The duration to insert a fixed batch of leaves into each tree type. | Metric | 1 leaves | 16 leaves | 64 leaves | 128 leaves | 256 leaves | 512 leaves | 1024 leaves | | - | - | - | - | - | - | - | - | batch_insert_into_append_only_tree_16_depth_ms | 10.4 (+1%) | 16.8 (+1%) | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_count | 16.8 | 31.7 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_ms | 0.602 (+1%) | 0.515 (+1%) | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_32_depth_ms | N/A | N/A | 48.4 | 76.2 | 131 (-1%) | 246 | 471 | batch_insert_into_append_only_tree_32_depth_hash_count | N/A | N/A | 95.9 | 159 | 287 | 543 | 1,055 | batch_insert_into_append_only_tree_32_depth_hash_ms | N/A | N/A | 0.494 (+1%) | 0.468 | 0.449 (-1%) | 0.445 | 0.440 | batch_insert_into_indexed_tree_20_depth_ms | N/A | N/A | 59.7 (+1%) | 112 | 182 | 354 (+1%) | 693 | batch_insert_into_indexed_tree_20_depth_hash_count | N/A | N/A | 109 | 207 | 355 | 691 | 1,363 | batch_insert_into_indexed_tree_20_depth_hash_ms | N/A | N/A | 0.505 (+1%) | 0.504 (+1%) | 0.482 | 0.478 | 0.475 | batch_insert_into_indexed_tree_40_depth_ms | N/A | N/A | 73.0 (+1%) | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_count | N/A | N/A | 133 | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_ms | N/A | N/A | 0.519 | N/A | N/A | N/A | N/A | ### Miscellaneous Transaction sizes based on how many contract classes are registered in the tx. | Metric | 0 registered classes | 1 registered classes | | - | - | - | tx_size_in_bytes | 85,672 | 670,983 | Transaction size based on fee payment method | Metric | | | - | |