chore(avm): remove trailing minus zero in codegen

[IlyasRidhuan]

Please read contributing guidelines and remove this line.

[IlyasRidhuan]

• #7185 👈
• #7178
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @IlyasRidhuan and the rest of your teammates on Graphite

[AztecBot]

Benchmark results

Metrics with a significant change:

• proof_construction_time_sha256_30_ms (16): 1,799 (+29%)
• avm_simulation_time_ms (Token:mint_public): 631 (+901%)
• avm_simulation_time_ms (Token:assert_minter_and_mint): 59.9 (-71%)
• app_circuit_proving_time_in_ms (AuthRegistry:set_authorized (avm)): 1,646 (+21%)
• app_circuit_proving_time_in_ms (FPC:prepare_fee (avm)): 4,739 (-19%)
• app_circuit_proving_time_in_ms (FPC:pay_refund (avm)): 8,878 (-21%)
• protocol_circuit_witness_generation_time_in_ms (root-rollup): 73.9 (-34%)
• protocol_circuit_proving_time_in_ms (private-kernel-tail): 46,219 (-18%)
• protocol_circuit_proving_time_in_ms (private-kernel-tail-to-public): 84,518 (-19%)
• protocol_circuit_proving_time_in_ms (root-parity): 33,878 (-17%)
• protocol_circuit_proving_time_in_ms (public-kernel-app-logic): 39,569 (-16%)
• protocol_circuit_proving_time_in_ms (public-kernel-teardown): 40,027 (-17%)
• protocol_circuit_proving_time_in_ms (root-rollup): 19,625 (-21%)

Detailed results

All benchmarks are run on txs on the `Benchmarking` contract on the repository. Each tx consists of a batch call to `create_note` and `increment_balance`, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write. This benchmark source data is available in JSON format on S3 [here](https://aztec-ci-artifacts.s3.us-east-2.amazonaws.com/benchmarks-v1/pulls/7185.json). ### Proof generation Each column represents the number of threads used in proof generation. | Metric | 1 threads | 4 threads | 16 threads | 32 threads | 64 threads | | - | - | - | - | - | - | proof_construction_time_sha256_30_ms | 11,532 | 3,139 (+1%) | :warning: 1,799 (**+29%**) | 1,604 (-3%) | 1,532 (+5%) | proof_construction_time_sha256_100_ms | 44,338 | 11,994 (+1%) | 5,520 (+2%) | 5,402 | 5,407 (+1%) | proof_construction_time_poseidon_hash_ms | 79.0 | 34.0 | 34.0 | 58.0 (+2%) | 86.0 (-1%) | proof_construction_time_poseidon_hash_30_ms | 1,534 | 420 | 201 (+1%) | 229 (+5%) | 269 (+1%) | proof_construction_time_poseidon_hash_100_ms | 5,810 | 1,586 | 722 (+1%) | 779 (-1%) | 801 (+1%) | ### L2 block published to L1 Each column represents the number of txs on an L2 block published to L1. | Metric | 4 txs | 8 txs | 16 txs | | - | - | - | - | l1_rollup_calldata_size_in_bytes | 1,412 | 1,412 | 1,412 | l1_rollup_calldata_gas | 9,452 | 9,460 | 9,476 | l1_rollup_execution_gas | 610,273 | 610,281 | 610,297 | l2_block_processing_time_in_ms | 761 (+1%) | 1,409 | 2,690 | l2_block_building_time_in_ms | 25,821 (+3%) | 50,531 | 100,491 (+1%) | l2_block_rollup_simulation_time_in_ms | 25,821 (+3%) | 50,530 | 100,490 (+1%) | l2_block_public_tx_process_time_in_ms | 22,175 (+3%) | 46,791 | 96,722 (+1%) | ### L2 chain processing Each column represents the number of blocks on the L2 chain where each block has 8 txs. | Metric | 3 blocks | 5 blocks | | - | - | - | node_history_sync_time_in_ms | 6,988 | 9,857 | node_database_size_in_bytes | 12,148,816 | 16,027,728 | pxe_database_size_in_bytes | 16,254 | 26,813 | ### Circuits stats Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks. | Circuit | simulation_time_in_ms | witness_generation_time_in_ms | proving_time_in_ms | input_size_in_bytes | output_size_in_bytes | proof_size_in_bytes | num_public_inputs | size_in_gates | | - | - | - | - | - | - | - | - | - | private-kernel-init | 131 (+2%) | 495 (+4%) | 12,225 (-5%) | 20,634 | 67,190 | 92,352 | 2,819 | 524,288 | private-kernel-inner | 393 (+1%) | 1,058 (-5%) | 45,126 (-9%) | 94,902 | 67,190 | 92,352 | 2,819 | 2,097,152 | private-kernel-tail | 371 (+1%) | 1,892 (+3%) | :warning: 46,219 (**-18%**) | 99,121 | 71,733 | 14,912 | 399 | 2,097,152 | base-parity | 6.31 (-1%) | 1,984 (+4%) | 2,606 (-7%) | 128 | 64.0 | 2,208 | 2.00 | 131,072 | root-parity | 49.3 (+1%) | 57.0 (-25%) | :warning: 33,878 (**-17%**) | 27,100 | 64.0 | 2,720 | 18.0 | 2,097,152 | base-rollup | 7,884 | 5,015 (+4%) | 72,008 (-15%) | 170,330 | 756 | 3,648 | 47.0 | 4,194,304 | root-rollup | 112 (+3%) | :warning: 73.9 (**-34%**) | :warning: 19,625 (**-21%**) | 25,309 | 620 | 3,456 | 41.0 | 1,048,576 | public-kernel-setup | 723 (+1%) | 3,656 (-1%) | 38,974 (-13%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | public-kernel-app-logic | 615 (+1%) | 4,821 (-1%) | :warning: 39,569 (**-16%**) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | public-kernel-tail | 1,416 (+1%) | 36,689 (+2%) | 166,225 (-15%) | 511,910 | 10,014 | 14,912 | 399 | 8,388,608 | private-kernel-reset-small | 595 (+1%) | 2,220 (+13%) | 40,863 (-14%) | 123,313 | 67,190 | 92,352 | 2,819 | 2,097,152 | public-kernel-teardown | 618 | 4,804 (+2%) | :warning: 40,027 (**-17%**) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | merge-rollup | 29.2 | N/A | N/A | 16,542 | 756 | N/A | N/A | N/A | private-kernel-tail-to-public | N/A | 7,160 (+5%) | :warning: 84,518 (**-19%**) | N/A | N/A | 125,344 | 3,850 | 4,194,304 | Stats on running time collected for app circuits | Function | input_size_in_bytes | output_size_in_bytes | witness_generation_time_in_ms | proof_size_in_bytes | proving_time_in_ms | size_in_gates | num_public_inputs | | - | - | - | - | - | - | - | - | ContractClassRegisterer:register | 1,344 | 9,944 | 427 (+1%) | N/A | N/A | N/A | N/A | ContractInstanceDeployer:deploy | 1,408 | 9,944 | 40.5 (+2%) | N/A | N/A | N/A | N/A | MultiCallEntrypoint:entrypoint | 1,920 | 9,944 | 1,808 (+2%) | N/A | N/A | N/A | N/A | GasToken:deploy | 1,376 | 9,944 | 1,003 (+2%) | N/A | N/A | N/A | N/A | SchnorrAccount:constructor | 1,312 | 9,944 | 1,444 (+3%) | N/A | N/A | N/A | N/A | SchnorrAccount:entrypoint | 2,304 | 9,944 | 2,865 (+2%) | 16,768 | 50,890 (-10%) | 2,097,152 | 457 | Token:privately_mint_private_note | 1,280 | 9,944 | 1,701 (+5%) | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_public | 1,344 | 9,944 | 377 (+5%) | 16,768 | 10,559 (-6%) | 524,288 | 457 | Token:transfer | 1,312 | 9,944 | 4,570 (+1%) | 16,768 | 41,765 (-13%) | 2,097,152 | 457 | AuthRegistry:set_authorized (avm) | 21,043 | N/A | N/A | 87,200 | :warning: 1,646 (**+21%**) | N/A | N/A | FPC:prepare_fee (avm) | 28,553 | N/A | N/A | 88,032 | :warning: 4,739 (**-19%**) | N/A | N/A | Token:transfer_public (avm) | 44,885 | N/A | N/A | 87,754 | 3,509 (-13%) | N/A | N/A | AuthRegistry:consume (avm) | 34,973 | N/A | N/A | 87,616 | 2,792 (-6%) | N/A | N/A | FPC:pay_refund (avm) | 33,413 | N/A | N/A | 88,448 | :warning: 8,878 (**-21%**) | N/A | N/A | Benchmarking:create_note | 1,344 | 9,944 | 1,433 (+3%) | N/A | N/A | N/A | N/A | SchnorrAccount:verify_private_authwit | 1,280 | 9,944 | 73.9 (+1%) | N/A | N/A | N/A | N/A | Token:unshield | 1,376 | 9,944 | 3,793 (+2%) | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_private | 1,376 | 9,944 | 4,728 (+1%) | N/A | N/A | N/A | N/A | ### AVM Simulation Time to simulate various public functions in the AVM. | Function | time_ms | bytecode_size_in_bytes | | - | - | - | GasToken:_increase_public_balance | 67.5 (-1%) | 13,873 | GasToken:set_portal | 16.6 (-2%) | 3,495 | Token:constructor | 94.1 (+2%) | 24,207 | FPC:constructor | 63.3 (-4%) | 13,893 | GasToken:mint_public | 44.7 (-15%) | 10,241 | Token:mint_public | :warning: 631 (**+901%**) | 19,216 | Token:assert_minter_and_mint | :warning: 59.9 (**-71%**) | 13,034 | AuthRegistry:set_authorized | 31.2 (-4%) | 7,869 | FPC:prepare_fee | 180 (-10%) | 15,187 | Token:transfer_public | 35.7 (+2%) | 31,425 | FPC:pay_refund | 116 (-11%) | 20,080 | Benchmarking:increment_balance | 2,686 | 15,465 | Token:_increase_public_balance | 56.0 | 15,089 | FPC:pay_refund_with_shielded_rebate | 146 (-1%) | 21,167 | ### Public DB Access Time to access various public DBs. | Function | time_ms | | - | - | get-nullifier-index | 0.146 (-6%) | ### Tree insertion stats The duration to insert a fixed batch of leaves into each tree type. | Metric | 1 leaves | 16 leaves | 64 leaves | 128 leaves | 256 leaves | 512 leaves | 1024 leaves | | - | - | - | - | - | - | - | - | batch_insert_into_append_only_tree_16_depth_ms | 10.4 (+1%) | 16.8 (+1%) | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_count | 16.8 | 31.7 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_ms | 0.602 (+1%) | 0.517 (+1%) | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_32_depth_ms | N/A | N/A | 48.8 | 76.3 (+1%) | 132 (+1%) | 244 | 470 | batch_insert_into_append_only_tree_32_depth_hash_count | N/A | N/A | 95.9 | 159 | 287 | 543 | 1,055 | batch_insert_into_append_only_tree_32_depth_hash_ms | N/A | N/A | 0.499 (+1%) | 0.468 (+1%) | 0.454 (+1%) | 0.442 | 0.439 | batch_insert_into_indexed_tree_20_depth_ms | N/A | N/A | 60.2 (+2%) | 112 | 184 (+1%) | 353 (+1%) | 692 | batch_insert_into_indexed_tree_20_depth_hash_count | N/A | N/A | 109 | 207 | 355 | 691 | 1,363 | batch_insert_into_indexed_tree_20_depth_hash_ms | N/A | N/A | 0.510 (+2%) | 0.502 | 0.488 (+1%) | 0.477 | 0.475 | batch_insert_into_indexed_tree_40_depth_ms | N/A | N/A | 73.0 | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_count | N/A | N/A | 133 | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_ms | N/A | N/A | 0.520 (+1%) | N/A | N/A | N/A | N/A | ### Miscellaneous Transaction sizes based on how many contract classes are registered in the tx. | Metric | 0 registered classes | 1 registered classes | | - | - | - | tx_size_in_bytes | 85,672 | 670,983 | Transaction size based on fee payment method | Metric | | | - | |