search

AztecProtocol / aztec-packages

Apache License 2.0
155 stars 157 forks source link

feat: remove event selector in logs from public context #7192

Closed sklppy88 closed 6 days ago

sklppy88 commented 1 week ago

Please read contributing guidelines and remove this line.

sklppy88 commented 1 week ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sklppy88 and the rest of your teammates on Graphite Graphite

AztecBot commented 6 days ago

Benchmark results

Metrics with a significant change:

Detailed results All benchmarks are run on txs on the `Benchmarking` contract on the repository. Each tx consists of a batch call to `create_note` and `increment_balance`, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write. This benchmark source data is available in JSON format on S3 [here](https://aztec-ci-artifacts.s3.us-east-2.amazonaws.com/benchmarks-v1/pulls/7192.json). ### Proof generation Each column represents the number of threads used in proof generation. | Metric | 1 threads | 4 threads | 16 threads | 32 threads | 64 threads | | - | - | - | - | - | - | proof_construction_time_sha256_30_ms | 11,760 (+4%) | 3,216 (+5%) | :warning: 1,721 (**+19%**) | 1,626 (+12%) | 1,481 (-10%) | proof_construction_time_sha256_100_ms | 43,942 (-1%) | 11,805 | 5,463 (+2%) | 5,408 (+1%) | 5,368 (-1%) | proof_construction_time_poseidon_hash_ms | 78.0 | 34.0 | 34.0 | 57.0 (-3%) | 88.0 (-2%) | proof_construction_time_poseidon_hash_30_ms | 1,518 | 417 (+1%) | 200 | 220 (-4%) | 268 (-1%) | proof_construction_time_poseidon_hash_100_ms | 5,752 | 1,579 (+1%) | 726 (+1%) | 775 | 792 | ### L2 block published to L1 Each column represents the number of txs on an L2 block published to L1. | Metric | 4 txs | 8 txs | 16 txs | | - | - | - | - | l1_rollup_calldata_size_in_bytes | 1,412 | 1,412 | 1,412 | l1_rollup_calldata_gas | 9,476 | 9,464 | 9,464 | l1_rollup_execution_gas | 610,297 | 610,285 | 610,285 | l2_block_processing_time_in_ms | 749 | 1,404 | 2,647 (-1%) | l2_block_building_time_in_ms | 24,868 (-2%) | 50,664 (-1%) | 97,134 (-3%) | l2_block_rollup_simulation_time_in_ms | 24,868 (-2%) | 50,664 (-1%) | 97,134 (-3%) | l2_block_public_tx_process_time_in_ms | 21,340 (-2%) | 46,900 (-1%) | 93,492 (-3%) | ### L2 chain processing Each column represents the number of blocks on the L2 chain where each block has 8 txs. | Metric | 3 blocks | 5 blocks | | - | - | - | node_history_sync_time_in_ms | 7,048 | 9,822 | node_database_size_in_bytes | 12,169,296 | 16,089,168 | pxe_database_size_in_bytes | 16,254 | 26,813 | ### Circuits stats Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks. | Circuit | simulation_time_in_ms | witness_generation_time_in_ms | proving_time_in_ms | input_size_in_bytes | output_size_in_bytes | proof_size_in_bytes | num_public_inputs | size_in_gates | | - | - | - | - | - | - | - | - | - | private-kernel-init | 131 (+1%) | 496 (-5%) | 12,480 (+2%) | 20,634 | 67,190 | 92,352 | 2,819 | 524,288 | private-kernel-inner | 396 | 1,115 (+2%) | 44,656 (-1%) | 94,902 | 67,190 | 92,352 | 2,819 | 2,097,152 | private-kernel-tail | 368 (-1%) | 1,980 (+6%) | 45,571 (-1%) | 99,121 | 71,733 | 14,912 | 399 | 2,097,152 | base-parity | 6.18 (-7%) | 1,931 (-3%) | 2,594 | 128 | 64.0 | 2,208 | 2.00 | 131,072 | root-parity | 49.9 | 58.0 (-2%) | 34,178 (+2%) | 27,100 | 64.0 | 2,720 | 18.0 | 2,097,152 | base-rollup | 7,839 (-2%) | 4,974 (-2%) | 72,103 | 170,330 | 756 | 3,648 | 47.0 | 4,194,304 | root-rollup | 115 (+3%) | 78.3 (+10%) | 19,357 (-2%) | 25,309 | 620 | 3,456 | 41.0 | 1,048,576 | public-kernel-setup | 737 (+1%) | 3,647 (-1%) | 38,862 (-1%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | public-kernel-app-logic | 609 (-1%) | 4,817 | 39,696 (-3%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | public-kernel-tail | 1,410 (-1%) | 37,346 (+7%) | 165,596 | 511,910 | 10,014 | 14,912 | 399 | 8,388,608 | private-kernel-reset-small | 597 | 2,185 | 41,182 (-1%) | 123,313 | 67,190 | 92,352 | 2,819 | 2,097,152 | public-kernel-teardown | 632 (+1%) | 4,783 | 40,343 (-1%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | merge-rollup | 28.8 | N/A | N/A | 16,542 | 756 | N/A | N/A | N/A | private-kernel-tail-to-public | N/A | 7,265 (-6%) | 85,001 (+1%) | N/A | N/A | 125,344 | 3,850 | 4,194,304 | Stats on running time collected for app circuits | Function | input_size_in_bytes | output_size_in_bytes | witness_generation_time_in_ms | proof_size_in_bytes | proving_time_in_ms | size_in_gates | num_public_inputs | | - | - | - | - | - | - | - | - | ContractClassRegisterer:register | 1,344 | 9,944 | 428 (+1%) | N/A | N/A | N/A | N/A | ContractInstanceDeployer:deploy | 1,408 | 9,944 | 40.2 (-1%) | N/A | N/A | N/A | N/A | MultiCallEntrypoint:entrypoint | 1,920 | 9,944 | 1,791 | N/A | N/A | N/A | N/A | GasToken:deploy | 1,376 | 9,944 | 1,011 (+1%) | N/A | N/A | N/A | N/A | SchnorrAccount:constructor | 1,312 | 9,944 | 1,424 (-1%) | N/A | N/A | N/A | N/A | SchnorrAccount:entrypoint | 2,304 | 9,944 | 2,906 (+2%) | 16,768 | 50,798 | 2,097,152 | 457 | Token:privately_mint_private_note | 1,280 | 9,944 | 1,705 (-1%) | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_public | 1,344 | 9,944 | 377 | 16,768 | 10,458 (-1%) | 524,288 | 457 | Token:transfer | 1,312 | 9,944 | 4,595 | 16,768 | 41,302 | 2,097,152 | 457 | AuthRegistry:set_authorized (avm) | 21,043 | N/A | N/A | 87,200 | 1,609 (+4%) | N/A | N/A | FPC:prepare_fee (avm) | 28,521 | N/A | N/A | 88,032 | 4,717 (-4%) | N/A | N/A | AuthRegistry:consume (avm) | 34,973 | N/A | N/A | 87,616 | 2,827 (-1%) | N/A | N/A | Token:transfer_public (avm) | 44,849 | N/A | N/A | 87,616 | 2,862 (-1%) | N/A | N/A | FPC:pay_refund (avm) | 33,381 | N/A | N/A | 88,448 | 8,767 (-3%) | N/A | N/A | Benchmarking:create_note | 1,344 | 9,944 | 1,456 (+4%) | N/A | N/A | N/A | N/A | SchnorrAccount:verify_private_authwit | 1,280 | 9,944 | 84.5 (+15%) | N/A | N/A | N/A | N/A | Token:unshield | 1,376 | 9,944 | 3,782 (+2%) | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_private | 1,376 | 9,944 | 4,754 (+1%) | N/A | N/A | N/A | N/A | ### AVM Simulation Time to simulate various public functions in the AVM. | Function | time_ms | bytecode_size_in_bytes | | - | - | - | GasToken:_increase_public_balance | 68.6 (-2%) | 13,873 | GasToken:set_portal | 16.8 (+2%) | 3,495 | Token:constructor | 92.6 (-1%) | 24,207 | FPC:constructor | 64.3 (+3%) | 13,893 | GasToken:mint_public | 54.2 (+1%) | 10,241 | Token:mint_public | 75.1 (+11%) | 19,216 | Token:assert_minter_and_mint | 233 (+10%) | 13,034 | AuthRegistry:set_authorized | 32.0 | 7,869 | FPC:prepare_fee | 184 (+2%) | 15,187 | Token:transfer_public | 39.8 (-18%) | 31,425 | FPC:pay_refund | 125 (+6%) | 20,080 | Benchmarking:increment_balance | 2,664 (-2%) | 15,465 | Token:_increase_public_balance | 55.0 (-2%) | 15,089 | FPC:pay_refund_with_shielded_rebate | 143 (-3%) | 21,167 | ### Public DB Access Time to access various public DBs. | Function | time_ms | | - | - | get-nullifier-index | 0.162 (+11%) | ### Tree insertion stats The duration to insert a fixed batch of leaves into each tree type. | Metric | 1 leaves | 16 leaves | 64 leaves | 128 leaves | 256 leaves | 512 leaves | 1024 leaves | | - | - | - | - | - | - | - | - | batch_insert_into_append_only_tree_16_depth_ms | 10.5 (+1%) | 16.8 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_count | 16.8 | 31.7 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_ms | 0.606 | 0.516 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_32_depth_ms | N/A | N/A | 48.4 (-1%) | 75.7 | 132 (+1%) | 244 | 457 (-3%) | batch_insert_into_append_only_tree_32_depth_hash_count | N/A | N/A | 95.9 | 159 | 287 | 543 | 1,055 | batch_insert_into_append_only_tree_32_depth_hash_ms | N/A | N/A | 0.495 (-1%) | 0.465 | 0.452 (+1%) | 0.443 | 0.427 (-3%) | batch_insert_into_indexed_tree_20_depth_ms | N/A | N/A | 59.5 (-1%) | 111 (-1%) | 180 (-1%) | 351 | 676 (-3%) | batch_insert_into_indexed_tree_20_depth_hash_count | N/A | N/A | 109 | 207 | 355 | 691 | 1,363 | batch_insert_into_indexed_tree_20_depth_hash_ms | N/A | N/A | 0.504 (-1%) | 0.496 (-1%) | 0.477 (-1%) | 0.476 | 0.463 (-3%) | batch_insert_into_indexed_tree_40_depth_ms | N/A | N/A | 72.5 | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_count | N/A | N/A | 133 | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_ms | N/A | N/A | 0.516 (-1%) | N/A | N/A | N/A | N/A | ### Miscellaneous Transaction sizes based on how many contract classes are registered in the tx. | Metric | 0 registered classes | 1 registered classes | | - | - | - | tx_size_in_bytes | 85,672 | 670,983 | Transaction size based on fee payment method | Metric | | | - | |