search

AztecProtocol / aztec-packages

Apache License 2.0
181 stars 184 forks source link

fix(avm): fix unencryptedlog c++ deser #7194

Closed fcarreiro closed 3 months ago

fcarreiro commented 3 months ago

Note that I'm removing eventselector from the deserialization, because Esau has a PR open where he's removing it on the TS side.

Note also that the constraints/witgen for this opcode are still broken.

fcarreiro commented 3 months ago

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @fcarreiro and the rest of your teammates on Graphite Graphite

AztecBot commented 3 months ago

Docs Preview

Hey there! 👋 You can check your preview at https://667c10e67bb2cc44f9999783--aztec-docs-dev.netlify.app

AztecBot commented 3 months ago

Benchmark results

Metrics with a significant change:

Detailed results All benchmarks are run on txs on the `Benchmarking` contract on the repository. Each tx consists of a batch call to `create_note` and `increment_balance`, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write. This benchmark source data is available in JSON format on S3 [here](https://aztec-ci-artifacts.s3.us-east-2.amazonaws.com/benchmarks-v1/pulls/7194.json). ### Proof generation Each column represents the number of threads used in proof generation. | Metric | 1 threads | 4 threads | 16 threads | 32 threads | 64 threads | | - | - | - | - | - | - | proof_construction_time_sha256_30_ms | 11,415 (-2%) | 3,076 (-2%) | 1,461 (-1%) | 1,429 (-1%) | 1,443 (-8%) | proof_construction_time_sha256_100_ms | 44,126 (+3%) | 11,846 (+2%) | 5,443 (+1%) | 5,397 | 5,368 | proof_construction_time_poseidon_hash_ms | 78.0 (-1%) | 34.0 | 34.0 | 58.0 (+2%) | 88.0 | proof_construction_time_poseidon_hash_30_ms | 1,527 (+1%) | 417 (+1%) | 199 | 219 (-4%) | 263 (-2%) | proof_construction_time_poseidon_hash_100_ms | 5,773 (+2%) | 1,569 (-1%) | 723 | 773 (-3%) | 798 | ### L2 block published to L1 Each column represents the number of txs on an L2 block published to L1. | Metric | 4 txs | 8 txs | 16 txs | | - | - | - | - | l1_rollup_calldata_size_in_bytes | 1,412 | 1,412 | 1,412 | l1_rollup_calldata_gas | 9,476 | 9,466 | 9,476 | l1_rollup_execution_gas | 610,297 | 610,287 | 610,297 | l2_block_processing_time_in_ms | 758 (-1%) | 1,403 | 2,691 (-2%) | l2_block_building_time_in_ms | 25,463 (-1%) | 50,828 | 99,707 (-1%) | l2_block_rollup_simulation_time_in_ms | 25,462 (-1%) | 50,828 | 99,707 (-1%) | l2_block_public_tx_process_time_in_ms | 21,884 (-1%) | 47,076 | 96,017 (-1%) | ### L2 chain processing Each column represents the number of blocks on the L2 chain where each block has 8 txs. | Metric | 3 blocks | 5 blocks | | - | - | - | node_history_sync_time_in_ms | 6,973 (+1%) | 9,773 (+1%) | node_database_size_in_bytes | 12,128,336 | 16,064,592 | pxe_database_size_in_bytes | 16,254 | 26,813 | ### Circuits stats Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks. | Circuit | simulation_time_in_ms | witness_generation_time_in_ms | proving_time_in_ms | input_size_in_bytes | output_size_in_bytes | proof_size_in_bytes | num_public_inputs | size_in_gates | | - | - | - | - | - | - | - | - | - | private-kernel-init | 129 (-1%) | 478 (+3%) | 13,146 | 20,634 | 67,190 | 92,352 | 2,819 | 524,288 | private-kernel-inner | 393 | 974 (-3%) | 49,445 (+1%) | 94,902 | 67,190 | 92,352 | 2,819 | 2,097,152 | private-kernel-tail | 371 (-1%) | 1,830 (+2%) | 51,975 (+6%) | 99,121 | 71,733 | 14,912 | 399 | 2,097,152 | base-parity | 6.18 (+1%) | 1,932 (+5%) | 2,763 | 128 | 64.0 | 2,208 | 2.00 | 131,072 | root-parity | 49.2 (+1%) | 77.8 (-1%) | 39,726 (-4%) | 27,100 | 64.0 | 2,720 | 18.0 | 2,097,152 | base-rollup | 7,900 (-1%) | 4,964 (+4%) | 86,584 (+2%) | 170,330 | 756 | 3,648 | 47.0 | 4,194,304 | root-rollup | 110 (-1%) | 86.7 | 23,805 (-2%) | 25,309 | 620 | 3,456 | 41.0 | 1,048,576 | public-kernel-setup | 722 (+2%) | 3,723 (+3%) | 45,518 | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | public-kernel-app-logic | 614 | 4,703 (+3%) | 46,950 (+2%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | public-kernel-tail | 1,416 | 39,962 (+11%) | 189,985 (-3%) | 511,910 | 10,014 | 14,912 | 399 | 8,388,608 | private-kernel-reset-small | 595 (-1%) | 2,093 (-7%) | 46,415 (+1%) | 123,313 | 67,190 | 92,352 | 2,819 | 2,097,152 | public-kernel-teardown | 618 (+1%) | 4,757 (+4%) | 47,410 | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | merge-rollup | 28.6 (-1%) | N/A | N/A | 16,542 | 756 | N/A | N/A | N/A | private-kernel-tail-to-public | N/A | 7,029 (-13%) | 100,046 | N/A | N/A | 125,344 | 3,850 | 4,194,304 | Stats on running time collected for app circuits | Function | input_size_in_bytes | output_size_in_bytes | witness_generation_time_in_ms | proof_size_in_bytes | proving_time_in_ms | size_in_gates | num_public_inputs | | - | - | - | - | - | - | - | - | ContractClassRegisterer:register | 1,344 | 9,944 | 419 (-1%) | N/A | N/A | N/A | N/A | ContractInstanceDeployer:deploy | 1,408 | 9,944 | 39.7 (+1%) | N/A | N/A | N/A | N/A | MultiCallEntrypoint:entrypoint | 1,920 | 9,944 | 1,776 | N/A | N/A | N/A | N/A | GasToken:deploy | 1,376 | 9,944 | 982 (+2%) | N/A | N/A | N/A | N/A | SchnorrAccount:constructor | 1,312 | 9,944 | 1,408 | N/A | N/A | N/A | N/A | SchnorrAccount:entrypoint | 2,304 | 9,944 | 2,834 | 16,768 | 56,880 (+5%) | 2,097,152 | 457 | Token:privately_mint_private_note | 1,280 | 9,944 | :warning: 1,863 (**+16%**) | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_public | 1,344 | 9,944 | 359 (+3%) | 16,768 | 11,346 (+1%) | 524,288 | 457 | Token:transfer | 1,312 | 9,944 | 4,479 (+1%) | 16,768 | 46,332 (-2%) | 2,097,152 | 457 | AuthRegistry:set_authorized (avm) | 21,043 | N/A | N/A | 87,200 | 1,379 | N/A | N/A | FPC:prepare_fee (avm) | 28,521 | N/A | N/A | 88,032 | 5,748 (+1%) | N/A | N/A | AuthRegistry:consume (avm) | 34,973 | N/A | N/A | 87,616 | 3,046 (+2%) | N/A | N/A | Token:transfer_public (avm) | 44,849 | N/A | N/A | 87,616 | 3,061 (+3%) | N/A | N/A | FPC:pay_refund (avm) | 33,381 | N/A | N/A | 88,448 | 11,375 (+2%) | N/A | N/A | Benchmarking:create_note | 1,344 | 9,944 | 1,413 (+1%) | N/A | N/A | N/A | N/A | SchnorrAccount:verify_private_authwit | 1,280 | 9,944 | 73.3 | N/A | N/A | N/A | N/A | Token:unshield | 1,376 | 9,944 | 3,687 | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_private | 1,376 | 9,944 | 4,635 | N/A | N/A | N/A | N/A | ### AVM Simulation Time to simulate various public functions in the AVM. | Function | time_ms | bytecode_size_in_bytes | | - | - | - | GasToken:_increase_public_balance | 68.9 (+5%) | 13,873 | GasToken:set_portal | 17.1 | 3,495 | Token:constructor | 93.8 (+1%) | 24,207 | FPC:constructor | 64.0 (+2%) | 13,893 | GasToken:mint_public | 51.7 (-2%) | 10,241 | Token:mint_public | :warning: 611 (**+791%**) | 19,216 | Token:assert_minter_and_mint | :warning: 73.3 (**-65%**) | 13,034 | AuthRegistry:set_authorized | 33.1 (+2%) | 7,869 | FPC:prepare_fee | 188 (-3%) | 15,187 | Token:transfer_public | 38.0 (+9%) | 31,425 | FPC:pay_refund | 134 (+13%) | 20,080 | Benchmarking:increment_balance | 2,684 (-1%) | 15,465 | Token:_increase_public_balance | 56.9 | 15,089 | FPC:pay_refund_with_shielded_rebate | 150 (-2%) | 21,167 | ### Public DB Access Time to access various public DBs. | Function | time_ms | | - | - | get-nullifier-index | 0.152 (-5%) | ### Tree insertion stats The duration to insert a fixed batch of leaves into each tree type. | Metric | 1 leaves | 16 leaves | 64 leaves | 128 leaves | 256 leaves | 512 leaves | 1024 leaves | | - | - | - | - | - | - | - | - | batch_insert_into_append_only_tree_16_depth_ms | 10.3 | 16.7 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_count | 16.8 | 31.7 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_ms | 0.598 | 0.513 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_32_depth_ms | N/A | N/A | 48.3 (-1%) | 75.7 (-1%) | 131 (-2%) | 244 | 469 (-2%) | batch_insert_into_append_only_tree_32_depth_hash_count | N/A | N/A | 95.9 | 159 | 287 | 543 | 1,055 | batch_insert_into_append_only_tree_32_depth_hash_ms | N/A | N/A | 0.493 (-1%) | 0.466 (-1%) | 0.451 (-1%) | 0.442 | 0.437 (-2%) | batch_insert_into_indexed_tree_20_depth_ms | N/A | N/A | 59.5 | 112 (-1%) | 182 (-2%) | 352 | 695 (-1%) | batch_insert_into_indexed_tree_20_depth_hash_count | N/A | N/A | 109 | 207 | 355 | 691 | 1,363 | batch_insert_into_indexed_tree_20_depth_hash_ms | N/A | N/A | 0.503 | 0.500 (-1%) | 0.483 (-2%) | 0.477 | 0.478 (-1%) | batch_insert_into_indexed_tree_40_depth_ms | N/A | N/A | 72.7 (-1%) | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_count | N/A | N/A | 133 | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_ms | N/A | N/A | 0.518 | N/A | N/A | N/A | N/A | ### Miscellaneous Transaction sizes based on how many contract classes are registered in the tx. | Metric | 0 registered classes | 1 registered classes | | - | - | - | tx_size_in_bytes | 85,672 | 670,983 | Transaction size based on fee payment method | Metric | | | - | |
fcarreiro commented 3 months ago

Merge activity