AztecProtocol / aztec-packages

Apache License 2.0
155 stars 156 forks source link

fix: fix authwit package #7204

Closed TomAFrench closed 4 days ago

TomAFrench commented 4 days ago

https://github.com/AztecProtocol/aztec-packages/pull/7180 broke aztec-nr as it's renamed a function without updating all references to it

ludamad commented 4 days ago

thanks

AztecBot commented 4 days ago

Benchmark results

Metrics with a significant change:

Detailed results All benchmarks are run on txs on the `Benchmarking` contract on the repository. Each tx consists of a batch call to `create_note` and `increment_balance`, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write. This benchmark source data is available in JSON format on S3 [here](https://aztec-ci-artifacts.s3.us-east-2.amazonaws.com/benchmarks-v1/pulls/7204.json). ### Proof generation Each column represents the number of threads used in proof generation. | Metric | 1 threads | 4 threads | 16 threads | 32 threads | 64 threads | | - | - | - | - | - | - | proof_construction_time_sha256_30_ms | 11,407 | 3,058 | 1,441 (+4%) | 1,469 (-1%) | 1,620 (+5%) | proof_construction_time_sha256_100_ms | 43,765 | 11,796 (+1%) | 5,462 (+1%) | 5,428 (+1%) | 5,385 (+1%) | proof_construction_time_poseidon_hash_ms | 78.0 | 34.0 | 34.0 | 58.0 | 87.0 (-2%) | proof_construction_time_poseidon_hash_30_ms | 1,516 | 414 | 199 | 222 (-1%) | 268 (+2%) | proof_construction_time_poseidon_hash_100_ms | 5,753 | 1,563 (+1%) | 718 | 764 (+1%) | 794 (-1%) | ### L2 block published to L1 Each column represents the number of txs on an L2 block published to L1. | Metric | 4 txs | 8 txs | 16 txs | | - | - | - | - | l1_rollup_calldata_size_in_bytes | 1,412 | 1,412 | 1,412 | l1_rollup_calldata_gas | 9,476 | 9,460 | 9,464 | l1_rollup_execution_gas | 610,297 | 610,281 | 610,285 | l2_block_processing_time_in_ms | 748 (-2%) | 1,414 (+1%) | 2,682 (-1%) | l2_block_building_time_in_ms | 25,230 | 50,377 (-1%) | 99,151 | l2_block_rollup_simulation_time_in_ms | 25,230 | 50,377 (-1%) | 99,150 | l2_block_public_tx_process_time_in_ms | 21,676 | 46,633 (-1%) | 95,464 | ### L2 chain processing Each column represents the number of blocks on the L2 chain where each block has 8 txs. | Metric | 3 blocks | 5 blocks | | - | - | - | node_history_sync_time_in_ms | 7,044 (+1%) | 9,878 (+1%) | node_database_size_in_bytes | 12,181,584 | 16,121,936 | pxe_database_size_in_bytes | 16,254 | 26,813 | ### Circuits stats Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks. | Circuit | simulation_time_in_ms | witness_generation_time_in_ms | proving_time_in_ms | input_size_in_bytes | output_size_in_bytes | proof_size_in_bytes | num_public_inputs | size_in_gates | | - | - | - | - | - | - | - | - | - | private-kernel-init | 129 (-2%) | 503 | 12,008 | 20,634 | 67,190 | 92,352 | 2,819 | 524,288 | private-kernel-inner | 393 | 1,012 (-9%) | 44,614 (-1%) | 94,902 | 67,190 | 92,352 | 2,819 | 2,097,152 | private-kernel-tail | 368 (-1%) | 1,868 (-1%) | 46,392 | 99,121 | 71,733 | 14,912 | 399 | 2,097,152 | base-parity | 6.44 | 1,928 (-1%) | 2,566 (-1%) | 128 | 64.0 | 2,208 | 2.00 | 131,072 | root-parity | 49.3 (-1%) | 60.2 (+5%) | 34,065 | 27,100 | 64.0 | 2,720 | 18.0 | 2,097,152 | base-rollup | 7,852 (-1%) | 5,065 (+1%) | 72,401 | 170,330 | 756 | 3,648 | 47.0 | 4,194,304 | root-rollup | 112 | 74.4 | 19,492 | 25,309 | 620 | 3,456 | 41.0 | 1,048,576 | public-kernel-setup | 724 | 3,682 (+1%) | 38,878 (-1%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | public-kernel-app-logic | 608 (-1%) | 4,820 (-1%) | 40,726 | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | public-kernel-tail | 1,407 (-1%) | 35,284 (-7%) | 166,064 (-1%) | 511,910 | 10,014 | 14,912 | 399 | 8,388,608 | private-kernel-reset-small | 589 (-1%) | 2,056 (-3%) | 40,990 | 123,313 | 67,190 | 92,352 | 2,819 | 2,097,152 | public-kernel-teardown | 620 | 4,896 (+1%) | 40,405 (-1%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | merge-rollup | 29.1 (+1%) | N/A | N/A | 16,542 | 756 | N/A | N/A | N/A | private-kernel-tail-to-public | N/A | 7,254 | 85,455 (+1%) | N/A | N/A | 125,344 | 3,850 | 4,194,304 | Stats on running time collected for app circuits | Function | input_size_in_bytes | output_size_in_bytes | witness_generation_time_in_ms | proof_size_in_bytes | proving_time_in_ms | size_in_gates | num_public_inputs | | - | - | - | - | - | - | - | - | ContractClassRegisterer:register | 1,344 | 9,944 | 421 (-2%) | N/A | N/A | N/A | N/A | ContractInstanceDeployer:deploy | 1,408 | 9,944 | 40.7 | N/A | N/A | N/A | N/A | MultiCallEntrypoint:entrypoint | 1,920 | 9,944 | 1,811 | N/A | N/A | N/A | N/A | GasToken:deploy | 1,376 | 9,944 | 1,017 | N/A | N/A | N/A | N/A | SchnorrAccount:constructor | 1,312 | 9,944 | 1,447 | N/A | N/A | N/A | N/A | SchnorrAccount:entrypoint | 2,304 | 9,944 | 2,839 | 16,768 | 50,813 (-1%) | 2,097,152 | 457 | Token:privately_mint_private_note | 1,280 | 9,944 | 1,719 (+1%) | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_public | 1,344 | 9,944 | 389 (+3%) | 16,768 | 10,362 (-2%) | 524,288 | 457 | Token:transfer | 1,312 | 9,944 | 4,617 (+1%) | 16,768 | 41,365 (-1%) | 2,097,152 | 457 | AuthRegistry:set_authorized (avm) | 21,043 | N/A | N/A | 87,200 | 1,558 (-7%) | N/A | N/A | FPC:prepare_fee (avm) | 28,553 | N/A | N/A | 88,032 | 4,876 (+1%) | N/A | N/A | Token:transfer_public (avm) | 44,885 | N/A | N/A | 87,754 | :warning: 3,657 (**+26%**) | N/A | N/A | AuthRegistry:consume (avm) | 34,973 | N/A | N/A | 87,616 | 2,913 | N/A | N/A | FPC:pay_refund (avm) | 33,413 | N/A | N/A | 88,448 | 9,187 (+1%) | N/A | N/A | Benchmarking:create_note | 1,344 | 9,944 | 1,397 | N/A | N/A | N/A | N/A | SchnorrAccount:verify_private_authwit | 1,280 | 9,944 | 75.5 (+4%) | N/A | N/A | N/A | N/A | Token:unshield | 1,376 | 9,944 | 3,746 (+2%) | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_private | 1,376 | 9,944 | 4,710 (+2%) | N/A | N/A | N/A | N/A | ### AVM Simulation Time to simulate various public functions in the AVM. | Function | time_ms | bytecode_size_in_bytes | | - | - | - | GasToken:_increase_public_balance | 67.6 | 13,873 | GasToken:set_portal | 16.9 (-1%) | 3,495 | Token:constructor | 95.3 (-2%) | 24,207 | FPC:constructor | 64.8 (-3%) | 13,893 | GasToken:mint_public | 53.2 (-1%) | 10,241 | Token:mint_public | :warning: 637 (**+843%**) | 19,216 | Token:assert_minter_and_mint | :warning: 60.8 (**-73%**) | 13,034 | AuthRegistry:set_authorized | 31.9 (-1%) | 7,869 | FPC:prepare_fee | 146 (-21%) | 15,187 | Token:transfer_public | 35.0 (-7%) | 31,425 | FPC:pay_refund | 142 (+21%) | 20,080 | Benchmarking:increment_balance | 2,662 (-1%) | 15,465 | Token:_increase_public_balance | 56.5 | 15,089 | FPC:pay_refund_with_shielded_rebate | 154 (+5%) | 21,167 | ### Public DB Access Time to access various public DBs. | Function | time_ms | | - | - | get-nullifier-index | 0.147 (-1%) | ### Tree insertion stats The duration to insert a fixed batch of leaves into each tree type. | Metric | 1 leaves | 16 leaves | 64 leaves | 128 leaves | 256 leaves | 512 leaves | 1024 leaves | | - | - | - | - | - | - | - | - | batch_insert_into_append_only_tree_16_depth_ms | 10.4 | 16.9 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_count | 16.8 | 31.7 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_ms | 0.603 | 0.518 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_32_depth_ms | N/A | N/A | 48.8 | 75.6 (-1%) | 131 (-1%) | 244 | 469 | batch_insert_into_append_only_tree_32_depth_hash_count | N/A | N/A | 95.9 | 159 | 287 | 543 | 1,055 | batch_insert_into_append_only_tree_32_depth_hash_ms | N/A | N/A | 0.498 | 0.464 (-1%) | 0.450 (-1%) | 0.442 | 0.438 | batch_insert_into_indexed_tree_20_depth_ms | N/A | N/A | 60.1 | 112 | 182 (-1%) | 352 | 693 (-1%) | batch_insert_into_indexed_tree_20_depth_hash_count | N/A | N/A | 109 | 207 | 355 | 691 | 1,363 | batch_insert_into_indexed_tree_20_depth_hash_ms | N/A | N/A | 0.508 | 0.501 | 0.481 (-1%) | 0.476 | 0.474 (-1%) | batch_insert_into_indexed_tree_40_depth_ms | N/A | N/A | 72.9 | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_count | N/A | N/A | 133 | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_ms | N/A | N/A | 0.519 | N/A | N/A | N/A | N/A | ### Miscellaneous Transaction sizes based on how many contract classes are registered in the tx. | Metric | 0 registered classes | 1 registered classes | | - | - | - | tx_size_in_bytes | 85,672 | 670,983 | Transaction size based on fee payment method | Metric | | | - | |