search

AztecProtocol / aztec-packages

Apache License 2.0
155 stars 156 forks source link

chore: pull out noir-lang/noir#5120 #7205

Closed TomAFrench closed 4 days ago

TomAFrench commented 4 days ago

This PR pulls out a bunch of changes from #7170 which are just muddying the diff with noise.

AztecBot commented 4 days ago

Benchmark results

Metrics with a significant change:

Detailed results All benchmarks are run on txs on the `Benchmarking` contract on the repository. Each tx consists of a batch call to `create_note` and `increment_balance`, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write. This benchmark source data is available in JSON format on S3 [here](https://aztec-ci-artifacts.s3.us-east-2.amazonaws.com/benchmarks-v1/pulls/7205.json). ### Proof generation Each column represents the number of threads used in proof generation. | Metric | 1 threads | 4 threads | 16 threads | 32 threads | 64 threads | | - | - | - | - | - | - | proof_construction_time_sha256_30_ms | 11,449 (+1%) | 3,078 (+1%) | 1,397 (-4%) | 1,585 (+10%) | 1,585 (-3%) | proof_construction_time_sha256_100_ms | 43,898 | 11,889 (+1%) | :warning: 6,703 (**+24%**) | 5,979 (+11%) | 5,422 (+1%) | proof_construction_time_poseidon_hash_ms | 78.0 | :warning: 48.0 (**+41%**) | 34.0 | 57.0 (-2%) | 88.0 (+1%) | proof_construction_time_poseidon_hash_30_ms | 1,517 | 415 | 200 (-1%) | 228 | 266 (-3%) | proof_construction_time_poseidon_hash_100_ms | 5,760 (+1%) | 1,570 | 724 (+1%) | 782 (+2%) | 794 | ### L2 block published to L1 Each column represents the number of txs on an L2 block published to L1. | Metric | 4 txs | 8 txs | 16 txs | | - | - | - | - | l1_rollup_calldata_size_in_bytes | 1,412 | 1,412 | 1,412 | l1_rollup_calldata_gas | 9,452 | 9,460 | 9,452 | l1_rollup_execution_gas | 610,273 | 610,281 | 610,273 | l2_block_processing_time_in_ms | 752 | 1,407 (+3%) | 2,696 (-1%) | l2_block_building_time_in_ms | 25,526 | 50,419 (+2%) | 100,609 (+1%) | l2_block_rollup_simulation_time_in_ms | 25,526 | 50,419 (+2%) | 100,609 (+1%) | l2_block_public_tx_process_time_in_ms | 21,944 | 46,669 (+2%) | 96,868 (+1%) | ### L2 chain processing Each column represents the number of blocks on the L2 chain where each block has 8 txs. | Metric | 3 blocks | 5 blocks | | - | - | - | node_history_sync_time_in_ms | 6,951 (+2%) | 9,861 (+4%) | node_database_size_in_bytes | 12,161,104 | 16,089,168 | pxe_database_size_in_bytes | 16,254 | 26,813 | ### Circuits stats Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks. | Circuit | simulation_time_in_ms | witness_generation_time_in_ms | proving_time_in_ms | input_size_in_bytes | output_size_in_bytes | proof_size_in_bytes | num_public_inputs | size_in_gates | | - | - | - | - | - | - | - | - | - | private-kernel-init | 130 (+2%) | 568 (+13%) | 11,969 | 20,634 | 67,190 | 92,352 | 2,819 | 524,288 | private-kernel-inner | 392 (+1%) | 997 (-13%) | 44,805 | 94,902 | 67,190 | 92,352 | 2,819 | 2,097,152 | private-kernel-tail | 371 (+1%) | 1,869 | 45,527 (-1%) | 99,121 | 71,733 | 14,912 | 399 | 2,097,152 | base-parity | 6.46 (+1%) | 1,981 (+2%) | 2,595 (+3%) | 128 | 64.0 | 2,208 | 2.00 | 131,072 | root-parity | 49.7 (+1%) | 56.3 (-5%) | 34,001 (+1%) | 27,100 | 64.0 | 2,720 | 18.0 | 2,097,152 | base-rollup | 7,890 (+1%) | 5,049 (+1%) | 72,016 | 170,330 | 756 | 3,648 | 47.0 | 4,194,304 | root-rollup | 113 (+1%) | 72.4 (-5%) | 19,806 | 25,309 | 620 | 3,456 | 41.0 | 1,048,576 | public-kernel-setup | 724 (+1%) | 3,655 (-1%) | 38,815 (-1%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | public-kernel-app-logic | 612 (+1%) | 4,909 (+2%) | 40,253 (-1%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | public-kernel-tail | 1,412 (+1%) | 34,782 (-4%) | 164,544 | 511,910 | 10,014 | 14,912 | 399 | 8,388,608 | private-kernel-reset-small | 592 (+1%) | 2,214 (+4%) | 42,805 (+4%) | 123,313 | 67,190 | 92,352 | 2,819 | 2,097,152 | public-kernel-teardown | 623 (+1%) | 4,801 | 39,721 (-2%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | merge-rollup | 29.3 (-1%) | N/A | N/A | 16,542 | 756 | N/A | N/A | N/A | private-kernel-tail-to-public | N/A | 7,167 (-1%) | 84,249 (-1%) | N/A | N/A | 125,344 | 3,850 | 4,194,304 | Stats on running time collected for app circuits | Function | input_size_in_bytes | output_size_in_bytes | witness_generation_time_in_ms | proof_size_in_bytes | proving_time_in_ms | size_in_gates | num_public_inputs | | - | - | - | - | - | - | - | - | ContractClassRegisterer:register | 1,344 | 9,944 | 423 (-1%) | N/A | N/A | N/A | N/A | ContractInstanceDeployer:deploy | 1,408 | 9,944 | 40.5 | N/A | N/A | N/A | N/A | MultiCallEntrypoint:entrypoint | 1,920 | 9,944 | 1,807 | N/A | N/A | N/A | N/A | GasToken:deploy | 1,376 | 9,944 | 1,002 (-1%) | N/A | N/A | N/A | N/A | SchnorrAccount:constructor | 1,312 | 9,944 | 1,442 (+1%) | N/A | N/A | N/A | N/A | SchnorrAccount:entrypoint | 2,304 | 9,944 | 2,833 (+1%) | 16,768 | 52,597 (+4%) | 2,097,152 | 457 | Token:privately_mint_private_note | 1,280 | 9,944 | 1,707 | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_public | 1,344 | 9,944 | 382 (+1%) | 16,768 | 11,174 (+8%) | 524,288 | 457 | Token:transfer | 1,312 | 9,944 | 4,625 (+1%) | 16,768 | 40,997 | 2,097,152 | 457 | AuthRegistry:set_authorized (avm) | 21,043 | N/A | N/A | 87,200 | 1,600 (+3%) | N/A | N/A | FPC:prepare_fee (avm) | 28,553 | N/A | N/A | 88,032 | 4,704 (-2%) | N/A | N/A | Token:transfer_public (avm) | 44,885 | N/A | N/A | 87,754 | 3,715 (+4%) | N/A | N/A | AuthRegistry:consume (avm) | 34,973 | N/A | N/A | 87,616 | 2,948 (+7%) | N/A | N/A | FPC:pay_refund (avm) | 33,413 | N/A | N/A | 88,448 | 8,969 (+1%) | N/A | N/A | Benchmarking:create_note | 1,344 | 9,944 | 1,385 (+1%) | N/A | N/A | N/A | N/A | SchnorrAccount:verify_private_authwit | 1,280 | 9,944 | 74.4 (+2%) | N/A | N/A | N/A | N/A | Token:unshield | 1,376 | 9,944 | 3,739 (+1%) | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_private | 1,376 | 9,944 | 4,713 (+2%) | N/A | N/A | N/A | N/A | ### AVM Simulation Time to simulate various public functions in the AVM. | Function | time_ms | bytecode_size_in_bytes | | - | - | - | GasToken:_increase_public_balance | 68.0 (-4%) | 13,873 | GasToken:set_portal | 17.4 (+12%) | 3,495 | Token:constructor | 93.0 (-4%) | 24,207 | FPC:constructor | 64.5 | 13,893 | GasToken:mint_public | 55.2 (+4%) | 10,241 | Token:mint_public | 629 (+1%) | 19,216 | Token:assert_minter_and_mint | 73.2 (+15%) | 13,034 | AuthRegistry:set_authorized | 31.6 (-5%) | 7,869 | FPC:prepare_fee | 180 (+2%) | 15,187 | Token:transfer_public | 32.3 (-5%) | 31,425 | FPC:pay_refund | 124 (+1%) | 20,080 | Benchmarking:increment_balance | 2,687 (+2%) | 15,465 | Token:_increase_public_balance | 70.2 (+23%) | 15,089 | FPC:pay_refund_with_shielded_rebate | 150 | 21,167 | ### Public DB Access Time to access various public DBs. | Function | time_ms | | - | - | get-nullifier-index | 0.150 (+1%) | ### Tree insertion stats The duration to insert a fixed batch of leaves into each tree type. | Metric | 1 leaves | 16 leaves | 64 leaves | 128 leaves | 256 leaves | 512 leaves | 1024 leaves | | - | - | - | - | - | - | - | - | batch_insert_into_append_only_tree_16_depth_ms | 10.5 (+1%) | 16.9 (+2%) | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_count | 16.8 | 31.7 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_ms | 0.605 (+1%) | 0.521 (+2%) | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_32_depth_ms | N/A | N/A | 48.8 | 76.1 (+1%) | 131 | 244 (+3%) | 472 | batch_insert_into_append_only_tree_32_depth_hash_count | N/A | N/A | 95.9 | 159 | 287 | 543 | 1,055 | batch_insert_into_append_only_tree_32_depth_hash_ms | N/A | N/A | 0.498 | 0.467 (+1%) | 0.451 | 0.442 (+3%) | 0.440 | batch_insert_into_indexed_tree_20_depth_ms | N/A | N/A | 60.1 (+1%) | 112 (+2%) | 183 | 352 (+3%) | 693 (-2%) | batch_insert_into_indexed_tree_20_depth_hash_count | N/A | N/A | 109 | 207 | 355 | 691 | 1,363 | batch_insert_into_indexed_tree_20_depth_hash_ms | N/A | N/A | 0.508 (+1%) | 0.501 (+1%) | 0.483 | 0.476 (+3%) | 0.476 | batch_insert_into_indexed_tree_40_depth_ms | N/A | N/A | 73.2 (+1%) | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_count | N/A | N/A | 133 | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_ms | N/A | N/A | 0.521 (+1%) | N/A | N/A | N/A | N/A | ### Miscellaneous Transaction sizes based on how many contract classes are registered in the tx. | Metric | 0 registered classes | 1 registered classes | | - | - | - | tx_size_in_bytes | 85,672 | 670,983 | Transaction size based on fee payment method | Metric | | | - | |