AztecProtocol / aztec-packages

Apache License 2.0
180 stars 184 forks source link

chore: split off fuzzer, abi changes and `noirc_artifacts` from sync #7208

Closed TomAFrench closed 3 months ago

TomAFrench commented 3 months ago

This PR splits off a lot of the peripheral changes from the sync PR, namely the fuzzer, pushing ABI gen into noirc_driver, splitting noirc_artifacts out.

AztecBot commented 3 months ago

Benchmark results

Metrics with a significant change:

Detailed results All benchmarks are run on txs on the `Benchmarking` contract on the repository. Each tx consists of a batch call to `create_note` and `increment_balance`, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write. This benchmark source data is available in JSON format on S3 [here](https://aztec-ci-artifacts.s3.us-east-2.amazonaws.com/benchmarks-v1/pulls/7208.json). ### Proof generation Each column represents the number of threads used in proof generation. | Metric | 1 threads | 4 threads | 16 threads | 32 threads | 64 threads | | - | - | - | - | - | - | proof_construction_time_sha256_30_ms | 11,410 (-1%) | 3,061 (-1%) | :warning: 1,679 (**+21%**) | 1,445 (-13%) | 1,554 (+6%) | proof_construction_time_sha256_100_ms | 43,887 (-1%) | 11,746 (-1%) | 5,443 | 5,377 | 5,357 | proof_construction_time_poseidon_hash_ms | 77.0 (-3%) | 34.0 | 34.0 | 57.0 | 88.0 (+1%) | proof_construction_time_poseidon_hash_30_ms | 1,516 (-1%) | 415 (-1%) | 200 | 226 (+3%) | 264 (-1%) | proof_construction_time_poseidon_hash_100_ms | 5,751 (-1%) | 1,567 (-1%) | 720 | 789 (+1%) | 790 (-1%) | ### L2 block published to L1 Each column represents the number of txs on an L2 block published to L1. | Metric | 4 txs | 8 txs | 16 txs | | - | - | - | - | l1_rollup_calldata_size_in_bytes | 1,412 | 1,412 | 1,412 | l1_rollup_calldata_gas | 9,452 | 9,464 | 9,464 | l1_rollup_execution_gas | 610,273 | 610,285 | 610,285 | l2_block_processing_time_in_ms | 749 | 1,411 | 2,683 | l2_block_building_time_in_ms | 25,353 (+1%) | 50,995 (+1%) | 99,577 (+1%) | l2_block_rollup_simulation_time_in_ms | 25,353 (+1%) | 50,994 (+1%) | 99,577 (+1%) | l2_block_public_tx_process_time_in_ms | 21,791 (+1%) | 47,224 (+1%) | 95,811 | ### L2 chain processing Each column represents the number of blocks on the L2 chain where each block has 8 txs. | Metric | 3 blocks | 5 blocks | | - | - | - | node_history_sync_time_in_ms | 7,030 | 9,834 | node_database_size_in_bytes | 12,161,104 | 16,085,072 | pxe_database_size_in_bytes | 16,254 | 26,813 | ### Circuits stats Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks. | Circuit | simulation_time_in_ms | witness_generation_time_in_ms | proving_time_in_ms | input_size_in_bytes | output_size_in_bytes | proof_size_in_bytes | num_public_inputs | size_in_gates | | - | - | - | - | - | - | - | - | - | private-kernel-init | 130 (+1%) | 469 (-1%) | 13,119 (+2%) | 20,634 | 67,190 | 92,352 | 2,819 | 524,288 | private-kernel-inner | 391 (+1%) | :warning: 1,408 (**+27%**) | 48,893 (-2%) | 94,902 | 67,190 | 92,352 | 2,819 | 2,097,152 | private-kernel-tail | 371 (+1%) | 1,799 (-2%) | 52,306 (-7%) | 99,121 | 71,733 | 14,912 | 399 | 2,097,152 | base-parity | 6.29 (-1%) | 1,899 | 2,716 (-3%) | 128 | 64.0 | 2,208 | 2.00 | 131,072 | root-parity | 48.6 | 76.5 (+1%) | 40,730 | 27,100 | 64.0 | 2,720 | 18.0 | 2,097,152 | base-rollup | 7,915 (+1%) | 4,882 (+1%) | 85,087 | 170,330 | 756 | 3,648 | 47.0 | 4,194,304 | root-rollup | 110 (+1%) | 90.3 (-19%) | 24,294 (-3%) | 25,309 | 620 | 3,456 | 41.0 | 1,048,576 | public-kernel-setup | 713 (-1%) | 3,695 | 44,099 (-2%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | public-kernel-app-logic | 614 (+1%) | 4,674 (-4%) | 44,550 (-5%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | public-kernel-tail | 1,413 (+1%) | 37,430 (+4%) | 184,757 (-6%) | 511,910 | 10,014 | 14,912 | 399 | 8,388,608 | private-kernel-reset-small | 594 (+1%) | 2,059 (+5%) | 46,615 (-2%) | 123,313 | 67,190 | 92,352 | 2,819 | 2,097,152 | public-kernel-teardown | 613 | 4,670 (-1%) | 47,122 (-2%) | 116,905 | 93,334 | 125,344 | 3,850 | 2,097,152 | merge-rollup | 28.5 (-2%) | N/A | N/A | 16,542 | 756 | N/A | N/A | N/A | private-kernel-tail-to-public | N/A | 6,807 | 99,183 (-5%) | N/A | N/A | 125,344 | 3,850 | 4,194,304 | Stats on running time collected for app circuits | Function | input_size_in_bytes | output_size_in_bytes | witness_generation_time_in_ms | proof_size_in_bytes | proving_time_in_ms | size_in_gates | num_public_inputs | | - | - | - | - | - | - | - | - | ContractClassRegisterer:register | 1,344 | 9,944 | 424 (+1%) | N/A | N/A | N/A | N/A | ContractInstanceDeployer:deploy | 1,408 | 9,944 | 39.9 | N/A | N/A | N/A | N/A | MultiCallEntrypoint:entrypoint | 1,920 | 9,944 | 1,790 (+1%) | N/A | N/A | N/A | N/A | GasToken:deploy | 1,376 | 9,944 | 987 | N/A | N/A | N/A | N/A | SchnorrAccount:constructor | 1,312 | 9,944 | 1,432 (+2%) | N/A | N/A | N/A | N/A | SchnorrAccount:entrypoint | 2,304 | 9,944 | 2,830 | 16,768 | 56,163 (-1%) | 2,097,152 | 457 | Token:privately_mint_private_note | 1,280 | 9,944 | 1,642 (+1%) | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_public | 1,344 | 9,944 | 360 | 16,768 | 11,471 (+3%) | 524,288 | 457 | Token:transfer | 1,312 | 9,944 | 4,549 (+1%) | 16,768 | 45,610 (-5%) | 2,097,152 | 457 | AuthRegistry:set_authorized (avm) | 21,043 | N/A | N/A | 87,200 | 1,347 (-1%) | N/A | N/A | FPC:prepare_fee (avm) | 28,553 | N/A | N/A | 88,032 | 5,767 (-1%) | N/A | N/A | Token:transfer_public (avm) | 44,885 | N/A | N/A | 87,754 | 4,029 | N/A | N/A | AuthRegistry:consume (avm) | 34,973 | N/A | N/A | 87,616 | 2,971 | N/A | N/A | FPC:pay_refund (avm) | 33,413 | N/A | N/A | 88,448 | 11,158 | N/A | N/A | Benchmarking:create_note | 1,344 | 9,944 | 1,400 (+1%) | N/A | N/A | N/A | N/A | SchnorrAccount:verify_private_authwit | 1,280 | 9,944 | 74.8 (+2%) | N/A | N/A | N/A | N/A | Token:unshield | 1,376 | 9,944 | 3,779 (+2%) | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_private | 1,376 | 9,944 | 4,719 (+1%) | N/A | N/A | N/A | N/A | ### AVM Simulation Time to simulate various public functions in the AVM. | Function | time_ms | bytecode_size_in_bytes | | - | - | - | GasToken:_increase_public_balance | 68.8 (+1%) | 13,873 | GasToken:set_portal | 16.5 (-3%) | 3,495 | Token:constructor | 94.8 (+2%) | 24,207 | FPC:constructor | 63.3 (-4%) | 13,893 | GasToken:mint_public | 51.6 (-2%) | 10,241 | Token:mint_public | :warning: 612 (**+871%**) | 19,216 | Token:assert_minter_and_mint | :warning: 71.9 (**-66%**) | 13,034 | AuthRegistry:set_authorized | 32.0 (-1%) | 7,869 | FPC:prepare_fee | 177 (-12%) | 15,187 | Token:transfer_public | 35.4 (+1%) | 31,425 | FPC:pay_refund | 144 (+11%) | 20,080 | Benchmarking:increment_balance | 2,684 | 15,465 | Token:_increase_public_balance | 57.5 (+2%) | 15,089 | FPC:pay_refund_with_shielded_rebate | 141 (-5%) | 21,167 | ### Public DB Access Time to access various public DBs. | Function | time_ms | | - | - | get-nullifier-index | 0.148 (-5%) | ### Tree insertion stats The duration to insert a fixed batch of leaves into each tree type. | Metric | 1 leaves | 16 leaves | 64 leaves | 128 leaves | 256 leaves | 512 leaves | 1024 leaves | | - | - | - | - | - | - | - | - | batch_insert_into_append_only_tree_16_depth_ms | 10.3 | 16.7 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_count | 16.8 | 31.7 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_ms | 0.598 | 0.514 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_32_depth_ms | N/A | N/A | 48.6 | 75.9 | 131 | 245 | 466 (-1%) | batch_insert_into_append_only_tree_32_depth_hash_count | N/A | N/A | 95.9 | 159 | 287 | 543 | 1,055 | batch_insert_into_append_only_tree_32_depth_hash_ms | N/A | N/A | 0.496 | 0.466 | 0.449 | 0.445 | 0.436 (-1%) | batch_insert_into_indexed_tree_20_depth_ms | N/A | N/A | 59.6 (+1%) | 111 (-1%) | 182 | 353 (+1%) | 690 | batch_insert_into_indexed_tree_20_depth_hash_count | N/A | N/A | 109 | 207 | 355 | 691 | 1,363 | batch_insert_into_indexed_tree_20_depth_hash_ms | N/A | N/A | 0.505 (+1%) | 0.498 (-1%) | 0.481 | 0.477 | 0.473 (-1%) | batch_insert_into_indexed_tree_40_depth_ms | N/A | N/A | 72.9 | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_count | N/A | N/A | 133 | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_ms | N/A | N/A | 0.520 | N/A | N/A | N/A | N/A | ### Miscellaneous Transaction sizes based on how many contract classes are registered in the tx. | Metric | 0 registered classes | 1 registered classes | | - | - | - | tx_size_in_bytes | 85,672 | 670,983 | Transaction size based on fee payment method | Metric | | | - | |