feat: noncifying public note hashes

[benesjan]

Fixes #1386

[benesjan]

• #7293 👈
• #7273
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @benesjan and the rest of your teammates on Graphite

[github-actions[bot]]

Changes to circuit sizes

Generated at commit: d7032ead4c0cf1af11d027d98da5624ba0c58630, compared to commit: b5e2a6724084cfa576aeded78164e4dee222366f

🧾 Summary (100% most significant diffs)

Program	ACIR opcodes (+/-)	%	Circuit size (+/-)	%
public_kernel_app_logic	+16 ❌	+0.01%	+13,020 ❌	+0.78%
public_kernel_teardown	+16 ❌	+0.01%	+13,020 ❌	+0.78%

---

Full diff report 👇

| Program | ACIR opcodes (+/-) | % | Circuit size (+/-) | % | |:-|-:|-:|-:|-:| | **public_kernel_app_logic** | 242,697 (+16) | **+0.01%** | 1,676,225 (+13,020) | **+0.78%** | | **public_kernel_teardown** | 242,895 (+16) | **+0.01%** | 1,676,465 (+13,020) | **+0.78%** |

[AztecBot]

Benchmark results

Metrics with a significant change:

• avm_simulation_time_ms (Token:assert_minter_and_mint): 80.9 (+37%)

Detailed results

All benchmarks are run on txs on the `Benchmarking` contract on the repository. Each tx consists of a batch call to `create_note` and `increment_balance`, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write. This benchmark source data is available in JSON format on S3 [here](https://aztec-ci-artifacts.s3.us-east-2.amazonaws.com/benchmarks-v1/pulls/7293.json). ### Proof generation Each column represents the number of threads used in proof generation. | Metric | 1 threads | 4 threads | 16 threads | 32 threads | 64 threads | | - | - | - | - | - | - | proof_construction_time_sha256_ms | 5,724 | 1,542 | 713 (+1%) | 756 (-1%) | 780 (+1%) | proof_construction_time_sha256_30_ms | 11,935 (+1%) | 3,206 (+2%) | 1,469 (+4%) | 1,444 | 1,476 | proof_construction_time_sha256_100_ms | 44,017 (+1%) | 11,953 (+2%) | 5,668 (+4%) | 5,542 (+3%) | 5,475 (+2%) | proof_construction_time_poseidon_hash_ms | 79.0 (+3%) | 34.0 | 34.0 | 58.0 | 87.0 (-1%) | proof_construction_time_poseidon_hash_30_ms | 1,516 | 415 | 201 | 238 (+3%) | 265 (-3%) | proof_construction_time_poseidon_hash_100_ms | 5,738 | 1,560 | 733 (+1%) | 786 | 793 | ### L2 block published to L1 Each column represents the number of txs on an L2 block published to L1. | Metric | 4 txs | 8 txs | 16 txs | | - | - | - | - | l1_rollup_calldata_size_in_bytes | 1,412 | 1,412 | 1,412 | l1_rollup_calldata_gas | 9,452 | 9,470 | 9,476 | l1_rollup_execution_gas | 611,191 | 611,360 | 611,517 | l2_block_processing_time_in_ms | 765 | 1,426 | 2,720 (-1%) | l2_block_building_time_in_ms | 20,851 | 42,059 | 81,258 | l2_block_rollup_simulation_time_in_ms | 20,851 | 42,058 | 81,258 | l2_block_public_tx_process_time_in_ms | 17,841 | 38,815 | 78,119 (-1%) | ### L2 chain processing Each column represents the number of blocks on the L2 chain where each block has 8 txs. | Metric | 3 blocks | 5 blocks | | - | - | - | node_history_sync_time_in_ms | 7,097 (-1%) | 9,938 | node_database_size_in_bytes | 12,247,120 | 16,113,744 | pxe_database_size_in_bytes | 16,254 | 26,813 | ### Circuits stats Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks. | Circuit | simulation_time_in_ms | witness_generation_time_in_ms | proving_time_in_ms | input_size_in_bytes | output_size_in_bytes | proof_size_in_bytes | num_public_inputs | size_in_gates | | - | - | - | - | - | - | - | - | - | private-kernel-init | 102 | 391 (+1%) | 12,682 | 19,482 | 54,134 | 73,920 | 2,243 | 524,288 | private-kernel-inner | 309 | 770 (-9%) | 50,210 (-2%) | 80,694 | 54,134 | 73,920 | 2,243 | 2,097,152 | private-kernel-tail | 1,086 | 2,596 (+2%) | 49,963 (+2%) | 61,457 | 62,057 | 14,912 | 399 | 2,097,152 | base-parity | 6.29 (+2%) | 1,590 (+4%) | 2,743 | 128 | 64.0 | 2,208 | 2.00 | 131,072 | root-parity | 50.7 (+3%) | 67.4 (-4%) | 42,484 (-2%) | 27,100 | 64.0 | 2,720 | 18.0 | 2,097,152 | base-rollup | 6,579 (-1%) | 4,928 | 92,040 (+1%) | 170,330 | 728 | 3,648 | 47.0 | 4,194,304 | root-rollup | 111 | 80.3 | 23,714 | 25,253 | 620 | 3,456 | 41.0 | 1,048,576 | public-kernel-setup | 545 (+2%) | 2,454 | 43,415 | 102,121 | 80,278 | 106,912 | 3,274 | 2,097,152 | public-kernel-app-logic | 502 | 3,405 | 46,197 (+1%) | 102,121 | 80,278 | 106,912 | 3,274 | 2,097,152 | public-kernel-tail | 1,151 | 26,033 (-2%) | 185,194 (+1%) | 399,014 | 10,014 | 14,912 | 399 | 8,388,608 | private-kernel-reset-small | 469 | 1,093 (+1%) | 31,797 (+2%) | 109,233 | 54,134 | 73,920 | 2,243 | 1,048,576 | public-kernel-teardown | 494 (+1%) | 3,402 (-1%) | 44,928 | 102,121 | 80,278 | 106,912 | 3,274 | 2,097,152 | merge-rollup | 29.2 | N/A | N/A | 16,486 | 728 | N/A | N/A | N/A | private-kernel-tail-to-public | N/A | 8,541 (+1%) | 53,071 (+2%) | N/A | N/A | 106,912 | 3,274 | 2,097,152 | Stats on running time collected for app circuits | Function | input_size_in_bytes | output_size_in_bytes | witness_generation_time_in_ms | proof_size_in_bytes | proving_time_in_ms | size_in_gates | num_public_inputs | | - | - | - | - | - | - | - | - | ContractClassRegisterer:register | 1,344 | 8,792 | 408 | N/A | N/A | N/A | N/A | ContractInstanceDeployer:deploy | 1,408 | 8,792 | 38.9 | N/A | N/A | N/A | N/A | MultiCallEntrypoint:entrypoint | 1,920 | 8,792 | 1,200 (+1%) | N/A | N/A | N/A | N/A | GasToken:deploy | 1,376 | 8,792 | 901 (+1%) | N/A | N/A | N/A | N/A | SchnorrAccount:constructor | 1,312 | 8,792 | 503 (+2%) | N/A | N/A | N/A | N/A | SchnorrAccount:entrypoint | 2,304 | 8,792 | 1,637 | 14,720 | 54,046 (-4%) | 2,097,152 | 393 | Token:privately_mint_private_note | 1,280 | 8,792 | 629 (-1%) | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_public | 1,344 | 8,792 | 276 (+1%) | 14,720 | 11,885 (+2%) | 524,288 | 393 | Token:transfer | 1,312 | 8,792 | 1,821 (+2%) | 14,720 | 13,399 (+4%) | 524,288 | 393 | AuthRegistry:set_authorized (avm) | 19,226 | N/A | N/A | 91,264 | 1,294 (-8%) | N/A | N/A | FPC:prepare_fee (avm) | 26,668 | N/A | N/A | 91,328 | 2,929 (-4%) | N/A | N/A | Token:transfer_public (avm) | 42,918 | N/A | N/A | 91,328 | 3,923 (-7%) | N/A | N/A | AuthRegistry:consume (avm) | 33,104 | N/A | N/A | 91,264 | 2,790 (-8%) | N/A | N/A | FPC:pay_refund (avm) | 36,833 | N/A | N/A | 91,296 | 24,076 (-8%) | N/A | N/A | Benchmarking:create_note | 1,344 | 8,792 | 480 (-1%) | N/A | N/A | N/A | N/A | SchnorrAccount:verify_private_authwit | 1,280 | 8,792 | 75.9 (+5%) | N/A | N/A | N/A | N/A | Token:unshield | 1,376 | 8,792 | 1,537 | N/A | N/A | N/A | N/A | FPC:fee_entrypoint_private | 1,376 | 8,792 | 2,114 (-1%) | N/A | N/A | N/A | N/A | ### AVM Simulation Time to simulate various public functions in the AVM. | Function | time_ms | bytecode_size_in_bytes | | - | - | - | GasToken:_increase_public_balance | 71.6 (+4%) | 13,790 | GasToken:set_portal | 17.6 (+15%) | 3,339 | Token:constructor | 94.4 | 23,692 | FPC:constructor | 65.9 (-7%) | 13,592 | GasToken:mint_public | 53.8 (+3%) | 10,158 | Token:mint_public | 493 (-3%) | 19,034 | Token:assert_minter_and_mint | :warning: 80.9 (**+37%**) | 12,925 | AuthRegistry:set_authorized | 32.4 (+6%) | 7,812 | FPC:prepare_fee | 109 (+1%) | 15,062 | Token:transfer_public | 30.8 (-28%) | 31,218 | FPC:pay_refund | 133 (-3%) | 25,260 | Benchmarking:increment_balance | 2,202 | 15,267 | Token:_increase_public_balance | 56.4 (+1%) | 15,006 | FPC:pay_refund_with_shielded_rebate | 117 (-2%) | 26,347 | ### Public DB Access Time to access various public DBs. | Function | time_ms | | - | - | get-nullifier-index | 0.159 (-1%) | ### Tree insertion stats The duration to insert a fixed batch of leaves into each tree type. | Metric | 1 leaves | 16 leaves | 64 leaves | 128 leaves | 256 leaves | 512 leaves | 1024 leaves | | - | - | - | - | - | - | - | - | batch_insert_into_append_only_tree_16_depth_ms | 10.4 (-1%) | 16.8 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_count | 16.8 | 31.7 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_16_depth_hash_ms | 0.600 (-1%) | 0.515 | N/A | N/A | N/A | N/A | N/A | batch_insert_into_append_only_tree_32_depth_ms | N/A | N/A | 48.6 | 75.9 | 132 | 246 | 472 | batch_insert_into_append_only_tree_32_depth_hash_count | N/A | N/A | 95.9 | 159 | 287 | 543 | 1,055 | batch_insert_into_append_only_tree_32_depth_hash_ms | N/A | N/A | 0.496 | 0.465 | 0.452 | 0.445 | 0.440 | batch_insert_into_indexed_tree_20_depth_ms | N/A | N/A | 60.1 | 112 | 183 | 354 | 696 | batch_insert_into_indexed_tree_20_depth_hash_count | N/A | N/A | 109 | 207 | 355 | 691 | 1,363 | batch_insert_into_indexed_tree_20_depth_hash_ms | N/A | N/A | 0.506 | 0.502 | 0.483 | 0.479 | 0.477 | batch_insert_into_indexed_tree_40_depth_ms | N/A | N/A | 73.1 | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_count | N/A | N/A | 133 | N/A | N/A | N/A | N/A | batch_insert_into_indexed_tree_40_depth_hash_ms | N/A | N/A | 0.520 | N/A | N/A | N/A | N/A | ### Miscellaneous Transaction sizes based on how many contract classes are registered in the tx. | Metric | 0 registered classes | 1 registered classes | | - | - | - | tx_size_in_bytes | 74,057 | 667,850 | Transaction size based on fee payment method | Metric | | | - | |