search

AztecProtocol / aztec-packages

Apache License 2.0
173 stars 177 forks source link

bug: the tests in the token bridge has uninitialized vars #8198

Open FilipHarald opened 2 weeks ago

FilipHarald commented 2 weeks ago

The copied file is missing some objects that are used in the test. Below I post the error-msg, but the referenced vars that are not initalized are found here: a: https://github.com/AztecProtocol/aztec-packages/blob/aztec-packages-v0.50.1/yarn-project/end-to-end/src/e2e_cross_chain_messaging.test.ts#L137 b: https://github.com/AztecProtocol/aztec-packages/blob/aztec-packages-v0.50.1/yarn-project/end-to-end/src/e2e_public_cross_chain_messaging/deposits.test.ts#L102

Error-message when running the test:

    fixtures/shared/cross_chain_test_harness.test.ts:217:11 - error TS2304: Cannot find name 'rollup'.

    217     await rollup.write.setAssumeProvenUntilBlockNumber([
                  ~~~~~~
    fixtures/shared/cross_chain_test_harness.test.ts:218:13 - error TS2304: Cannot find name 'rollup'.

    218       await rollup.read.pendingBlockCount(),
                    ~~~~~~
    fixtures/shared/cross_chain_test_harness.test.ts:325:11 - error TS2304: Cannot find name 't'.

    325     await t.assumeProven();
                  ~
FilipHarald commented 2 weeks ago

I initially thought this was just a warning, but it also prevents the tests from running...

    test/cross_chain_test_harness.test.ts:75:23 - error TS7006: Parameter 'instance' implicitly has an 'any' type.

    75     ...instances.map((instance) => deployInstance(sender, instance!).request()),