search

AztecProtocol / aztec-packages

Apache License 2.0
210 stars 243 forks source link

Improve note metadata selectors #8694

Open Thunkar opened 2 months ago

Thunkar commented 2 months ago

Currently they don't really work for things that are bigger than a single Field (arrays, structs, etc) and are unnecessarily complicated. Also the macro might break when generating them.

Ideally the PropertySelector struct should be simplified to just the index of the field inside the note struct, using a similar strategy to what we currently do with events (providing a decode method) so that PXE can filter/select etc.

nventuro commented 2 months ago

Can you provide a simple example of how they're currently complicated, and what improving them might look like?