search

AztecProtocol / aztec-packages

Apache License 2.0
204 stars 234 forks source link

bug: Orchestrator tests explodes when gas and fees are non-zero #9900

Open LHerskind opened 1 week ago

LHerskind commented 1 week ago

There are a bunch of issues in the orchestrator test when you start having non-zero gas usage and prices.

As of #9868 the test a simply using 0 gas at 0 cost to avoid those pains as it worked in e2e.

However, when the values are non-zero, the output from public seems to still be 0, not taking fees or the summed into account. For private, the inclusion fee is accounted for when the header is computed in the orchestrator but not the gas. However circuits do account for them, so likely something with the mocks that are wrong.

In this slack thread is my descent into madness https://aztecprotocol.slack.com/archives/C04BTJAA694/p1731407517443459

LHerskind commented 1 week ago

Part of the issue might come from the following section. At least it would provide some insights into why the public behaved differently.

https://github.com/AztecProtocol/aztec-packages/blob/abdd912bd0d3cf9a8e09339a3766c61eea712ede/noir-projects/noir-protocol-circuits/crates/rollup-lib/src/base/public_base_rollup.nr#L89