search

AztecProtocol / aztec-verifier-contracts

28 stars 8 forks source link

Are `_proof` and `_publicInputs` actually unused? #20

Closed phated closed 1 year ago

phated commented 1 year ago

The linters in Remix IDE claim that _proof and _publicInputs variables on the verify function are unused. Is this just a false positive?

TomAFrench commented 1 year ago

This is a false positive. These two arguments are being read directly from calldata from within assembly by using the calldataload function.

solc is notoriously bad at not allowing us to disable warnings to the point that hardhat and foundry have patched around it: https://github.com/ethereum/solidity/issues/2675

LHerskind commented 1 year ago

As @TomAFrench says. We kept the names in there to make it more understandable, as just have two unnamed args can be pretty unhelpful.