AztecProtocol / barretenberg

Apache License 2.0
126 stars 77 forks source link

Fix batch mul issue that appears in recursive merge verifier #1024

Closed ledwards2225 closed 1 week ago

ledwards2225 commented 1 month ago

The Ultra arithmetized recursive merge verifier circuit fails due (I think) to a quirk in the Ultra batch mul. Reproduce this in a minimal test to diagnose then resolve.

Rumata888 commented 1 month ago

Can be fixed now with with_edgecases argument https://github.com/AztecProtocol/barretenberg/blob/43cfa7b3d1ee1bf404e2a086b7e9589cc73eaa66/cpp/src/barretenberg/stdlib/primitives/biggroup/biggroup_impl.hpp#L786