AztecProtocol / barretenberg

Apache License 2.0
133 stars 81 forks source link

Get rid of CommitmentTest? #210

Open codygunton opened 1 year ago

codygunton commented 1 year ago

What is this doing for us? I find it hard to navigate, wonder what others think.

codygunton commented 1 year ago

Is it implicitly assuming that we are going to want to test all commitment schemes with all possible sets of commitment scheme parameters? If not then why define CommitmentSchemeParams at the top level?