search

AztecProtocol / noir-starter

MIT License
168 stars 40 forks source link

Adds a stealthdrop example #27

Closed signorecello closed 1 year ago

netlify[bot] commented 1 year ago

Deploy Preview for noir-next-hardhat canceled.

Name Link
Latest commit e00171c1b33551a855919bf9efb175cec7faf460
Latest deploy log https://app.netlify.com/sites/noir-next-hardhat/deploys/6480687163436b0008f215d2
signorecello commented 1 year ago

Ready for review @critesjosh

critesjosh commented 1 year ago

Should you rebase this branch? It looks like it is missing a few of the examples that are in main.

signorecello commented 1 year ago

done @critesjosh 👍 also removed noir-lang/barretenberg and other dependencies causing trouble that aren't needed anymore

critesjosh commented 1 year ago

You mentioned bb.js doesn't play nice with hardhat. Can we move this project away from being a hardhat project?

It looks like the only hardhat thing that is used is npx hardhat test which could just be replaces with yarn test, is that right?

critesjosh commented 1 year ago

Also consider updating the README at the project root to include this.

signorecello commented 1 year ago

We also use hardhat to compile the circuits... We could use solc directly but it would compile everytime, I think hardhat is probably the better tool for this actually