AztecProtocol / noir-starter

MIT License
168 stars 40 forks source link

Fixed bug where datatypes are strings instead of numbers, this works … #43

Closed lipet2k closed 1 year ago

lipet2k commented 1 year ago

…fine with the given circuit example; however, this doesn't work when we want to perform operations

Description

Problem*

There is a difference between number.toString(16) and string.toString(16). A user who clones the repository may not know the difference and may use the component.ts file as reference. However, the user may face constraint errors since they wouldn't be able to perform their regular mathematical operations. This works for the demo circuit because we are just checking for non-equality, but would not work for another mathematical operation (e.g. multiplication).

Also removed unused parameter in function in NoirNode.

Summary*

Changed the input from String type to Number type.

Additional Context

:)

PR Checklist*

netlify[bot] commented 1 year ago

Deploy Preview for noir-next-hardhat ready!

Name Link
Latest commit 75cf62cbd597a91e2a356eafdf89e13aafdfbc42
Latest deploy log https://app.netlify.com/sites/noir-next-hardhat/deploys/64d3d781b1517e000806a424
Deploy Preview https://deploy-preview-43--noir-next-hardhat.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

critesjosh commented 1 year ago

thanks!