search

AztecProtocol / noir-starter

MIT License
168 stars 40 forks source link

Switch to using `noir_js` #51

Closed Savio-Sou closed 1 year ago

Savio-Sou commented 1 year ago 
### Helpful Prerequisite
- [ ] https://github.com/noir-lang/noir/issues/2711

Problem

noir-starter currently demonstrates the use of _acvmjs, while the new _noirjs is now released on NPM which could use a demonstration.

Happy Case

Update noir-starter to use _noirjs.

Additional Context

_noirjs is currently a wrapper for _acvmjs and _noirc_abiwasm. _acvmjs is used for Noir program execution (i.e. witness generation) and _noirc_abiwasm is a helper for encoding initial witness in preparation for execution / witness generation.

The compile_prove_verify.test.ts is a great reference for how to make use of _noirjs.

critesjosh commented 1 year ago

@signorecello can you take this one?

Savio-Sou commented 1 year ago

@signorecello good to call this closed with https://github.com/noir-lang/noir-starter/pull/54?

signorecello commented 1 year ago

yes sorry forgot to close it here