search

AztecProtocol / noir-starter

MIT License
168 stars 40 forks source link

feat: goodbye noir-starter, hello noirenberg #89

Closed signorecello closed 3 weeks ago

signorecello commented 1 month ago

Problem

Noir and BB versions were hard to sync. After some discussion, we agreed that there could be a tool to check the correct bb version for the wanted noir version.

As it wouldn't live inside the noir repository or even inside the noir-lang org (check #88), we thought it could have a creative name.

Description

Starts a refactor by extending the existent npx script to do this installation and check. It also moves it to ts using the excellent bun and tsx tooling.

I reckon I went a bit overboard with the dependencies on ora but I also wanted it to look good!

Next steps

netlify[bot] commented 1 month ago

Deploy Preview for noir-vite-hardhat canceled.

Name Link
Latest commit b4ca59be54daea59fe4c40b70367e5fc64f20084
Latest deploy log https://app.netlify.com/sites/noir-vite-hardhat/deploys/66fbd75fae606c0008e33cfe
signorecello commented 1 month ago

btw since this repo doesn't use release-please yet, you can actually already try the script with npx noirenberg as I have already published it

socket-security[bot] commented 1 month ago

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

🚮 Removed packages: npm/@inquirer/input@1.2.16, npm/@inquirer/select@1.3.3, npm/@inquirer/type@1.1.6, npm/@types/mute-stream@0.0.4, npm/@types/node@20.11.15, npm/@types/wrap-ansi@3.0.0, npm/chownr@2.0.0, npm/cli-width@4.1.0, npm/colorette@1.2.1, npm/commander@11.1.0, npm/debug@4.3.4, npm/enquirer@2.3.6, npm/figures@3.2.0, npm/fs-minipass@2.1.0, npm/fuzzysearch@1.0.3, npm/glob@7.2.3, npm/globalyzer@0.1.0, npm/globrex@0.1.2, npm/https-proxy-agent@5.0.0, npm/inflight@1.0.6, npm/inherits@2.0.4, npm/jsonfile@6.1.0, npm/minimatch@3.1.2, npm/minipass@3.3.6, npm/minizlib@2.1.2, npm/mri@1.1.6, npm/ms@2.1.2, npm/mute-stream@1.0.0, npm/once@1.4.0, npm/path-is-absolute@1.0.1, npm/react-dom@18.3.1, npm/react-toastify@9.1.3, npm/react@18.3.1, npm/rimraf@3.0.2, npm/run-async@3.0.0, npm/shelljs@0.8.5, npm/signal-exit@4.1.0, npm/solidity-coverage@0.8.13, npm/string-width@4.2.3, npm/tar@6.2.0, npm/tiged@2.12.6, npm/tiny-glob@0.2.8, npm/ts-node@10.9.2, npm/tsx@4.19.1, npm/type-fest@0.21.3, npm/typechain@8.3.2, npm/typescript@4.9.5, npm/undici-types@5.26.5, npm/universalify@2.0.1, npm/viem@2.21.16, npm/vite@5.4.8, npm/wagmi@2.10.0, npm/wrappy@1.0.2, npm/yallist@4.0.0

View full report↗︎

Savio-Sou commented 1 month ago

Note that hosting the noirenberg installation script in a standalone AztecProtocol repo (instead of as a part of the starter / boilerplate repo) might make more sense.