AzurLaneTools / AzurLaneData

Raw data extracted from AzurLane.
80 stars 17 forks source link

Missing Data #3

Closed Fernando2603 closed 1 year ago

Fernando2603 commented 1 year ago

Hi there, i noticed this file below missing some data in EN patch 6.2.188 (i only checked EN one, this should affected in other server folder as well)

EN/ShareCfg/activity_task_permanent.json EN/ShareCfg/benefit_buff_template.json EN/ShareCfg/box_data_template.json EN/ShareCfg/expedition_data_by_map.json EN/ShareCfg/furniture_data_template.json EN/ShareCfg/guild_base_event.json EN/ShareCfg/item_medal_fetch.json EN/ShareCfg/memory_group.json EN/ShareCfg/memory_template.json EN/ShareCfg/pay_level_award.json EN/ShareCfg/ship_data_group.json EN/ShareCfg/ship_meta_breakout.json EN/ShareCfg/ship_skin_template.json EN/ShareCfg/ship_skin_words_add.json EN/ShareCfg/ship_skin_words_extra.json EN/ShareCfg/shop_furniture_relation.json EN/ShareCfg/skill_data_display.json EN/ShareCfg/skill_data_template.json EN/ShareCfg/task_meta_data_template.json EN/ShareCfg/transform_data_template.json etc.

the new file data only contains __name and all key or whatever in pg.{filename} in AzurLaneLuaScripts

{
  "__name": "filename",
  "all": []
}

i assume this happened because in patch 6.2.88 the file got restructured so the data of listed id in all moved into pg.data.{filename} and current extracted data from Lua only get data from pg.{filename}

-- before
pg.{filename} = {
 [id]: { data },
 all: []
}
-- after
pg.{filename}= {
  _name: "filename",
  all: []
}
pg.data.{filename}= { data }

sorry for my bad english. Thank you!

AutumnSun1996 commented 1 year ago

Thanks for report. I've already found the problem, but have not time to fix it now. Should be able to find some time before next month, but no guarantees.

AutumnSun1996 commented 1 year ago

As a temporary workaround, you can use lua scripts in sharecfgdata folder of AzurLaneLuaScripts

ghost commented 1 year ago

I wanted to follow up on this issue from 2 weeks ago and ask if we should expect a fix to the problem by this month or next month. If not this month, that's fine, though it would be great to receive a notice on this.

I also want to bring up that the parsing issue with the EN patch is also affecting .json data from the CN, JP, KR, and TW patches. Same files affected, just different regions.

Data from EN/ShareCfg/activity_ins_language.json is also not being parsed correctly, as an addition to the list of data files mentioned in the OP. Thanks again for this repo. It's been a huge help for work and edits on the Azur Lane English Wiki.

ETATomorrow commented 1 year ago

It seems most of the data missing happened in the [region]/ShareCfg/.

I tried to parse the files in [region]/ShareCfg/ and pushed them to my repo. (I skipped word_template and word_legal_template)

I hope the files will be helpful while waiting for the repo to be fixed.

AutumnSun, thank you for the repo.

AutumnSun1996 commented 1 year ago

The extractor is updated to use pg.base[target_name] if available. The changes seems to introduced some other issues, but at least missing data here is back now.