AzuraCast / AzuraCast

A self-hosted web radio management suite, including turnkey installer tools for the full radio software stack and a modern, easy-to-use web app to manage your stations.
https://www.azuracast.com/
GNU Affero General Public License v3.0
3.02k stars 562 forks source link

The bug of nowplaying and gingle mode is back! #6215

Closed nunotfc closed 1 year ago

nunotfc commented 1 year ago

Installation Method

Docker Installation

AzuraCast Release Channel

Rolling Release Channel

Current AzuraCast Version

cdb3311 (2023-04-16 5:12) • Docker • PHP 8.2

What happened?

hello, the older bug of gingle mode and now playing is back! sometimes, not all time, song xx is played, after, play song xy and play a gingle. during playing of gingle, the xx name is shown in nowplaying..

Relevant log output

No response

Moonbase59 commented 1 year ago

I think that’s an intended feature, at least if you have set "Hide Metadata from Listeners ("Jingle Mode")" in a playlist, say, the station id playlist. It should show the jingles if this is not set.

nunotfc commented 1 year ago

yes, i agree, but it ahve to keep showing the song that played previously, and not one that played 1 or 3 songs ago. let me show you with a more consistent example. imagine you have playing the 1.mp3, 2.mp3, and 3.mp3. you play 1.mp3, play gingle, play 2.mp3. in the gingle before playing 3.mp3, im nowplaying it starts to show that is playing ,1.mp3 during the gingle playback, and not continue to show 2.mp3. it shows 1.mp3 during the jingle playback, and after plays and shows 3.mp3, that is correct.

Moonbase59 commented 1 year ago

Hm. Works here, or maybe I completely misunderstand you. For a try, I unset "Hide Metadata from Listeners ("Jingle Mode")" in my Station ID playlist, and waited until it hit in:

Auswahl_206

It played (and showed)

When I set "Hide Metadata from Listeners ("Jingle Mode")" in my Station ID playlist, it only shows

So the latter one is like what you experience.

nunotfc commented 1 year ago
      exactly. sorry for my english and if i was not so clear. but i think we can understand each oter now. the problem is not inmediately after you check the box, but 1 or 2 songs after it... i remember in the first times i used azuracast i reported same bug and it was fixed, i think a year or two ago, but it came back.
Moonbase59 commented 1 year ago

I still don’t understand—it is exactly as it should be: If I tell it to omit the jingle metadata, it does. And vice versa.

nunotfc commented 1 year ago

ahaa, i cant explain more... the bug is not with jingle mode... the bug is with now playing. when you are with jingle mode checked, instead of omiting the data, after the 2nd or 3rd song, sometimes, not forever, it shows a previous played song... if, for example, you play a song called "my love", and after you play a song called "lets go". with 1 jingle separating them. and you play a 3rd song called for example "good times". When the gingles that go from the "lets go" song to the "good times", instead of omiting data or continuing showing the "lets go"title, during the jingle selected to play it show s like "my love" song played other time, and, indeed, is just the jingle... i hope i can clarify more...

Moonbase59 commented 1 year ago

Ah, I think I grasp it now… Seems a possible bug indeed, probably some timing or race condition.

Moonbase59 commented 1 year ago

Are the jingles extremely short (a few seconds only)? You could try using longer jingles for a test, and see if it still happens then. Just in case it has something to do with crossfading and Liquidsoap not being fast enough or something…

nunotfc commented 1 year ago

right, all my jingles are like 2 or 3 secconds. in rare cases, 1.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 year ago

Thank you for your bug report, this issue has been closed due to inactivity. Should this issue persist, please re-open the bug report.