search

Azure-Agst / MapGilTracker

A Plugin to track gil earned from FATEs or Treasure Maps!
GNU General Public License v3.0
2 stars 0 forks source link

Differentiate between Achievements & Maps #4

Closed Azure-Agst closed 1 year ago

Azure-Agst commented 1 year ago

Major brought up a good point when I pitched the idea to him, mainly being the frequent reuse of the FATE popup for other things, like achievements.

It's important to note here that the plugin does not simply keep track of the differences in a player's gil over time. Since this tool explicitly hooks into the "FateReward" addon, it only keeps track of gil earned from sources that trigger said popup. (Only FATEs & Maps, at least to my current knowledge.)

MajorPainOG — Today at 5:00 PM
have you figured out how to seperate the gil earned from achivments?

azure — Today at 5:03 PM
Unsure, but probably? with some work. Essentially the plugin hooks into the FATE reward popup that appears upon opening chests or finishing a FATE and grabs the gil value from there.

MajorPainOG — Today at 5:03 PM
we had another fc membere make one but they could not figure that out

azure — Today at 5:03 PM
I imagine it wouldn't be too hard

MajorPainOG — Today at 5:04 PM
ya, if you could figure that out this plug-in would be very popular

azure — Today at 5:04 PM
Is there an example of an achievement that grants gil? I assume you mean like Hunting Log or Challenge log?

MajorPainOG — Today at 5:04 PM
i ahve asked for it for years in the dal discord
ya, they pop up and say you ahve earned such and such achivement here x gil

The best option here is probably a whitelist for the Title in the Popup's TextNode? I'll need to do some more research and see what all causes that popup to appear.

Azure-Agst commented 1 year ago

Update: Challenge Log achievements use their own popup. (Note the lack of "FateReward" addon under layer 5)

https://github.com/Azure-Agst/MapGilTracker/assets/10553730/fb99f595-86fe-4767-8a44-43702064015d

Azure-Agst commented 1 year ago

Hunting Log doesn't even give gil, just XP and seals.

Azure-Agst commented 1 year ago

Still have zero idea what other events trigger the FateReward addon. I guess we'll just have to find out via testing.

Azure-Agst commented 1 year ago

This seems to be mostly done! Gonna await results from tomorrow night to confirm.

Azure-Agst commented 1 year ago

I'm going to go ahead and say that this is fixed for now, but will re-open if it becomes problematic