Azure-Player / azure.datafactory.devops

Azure DevOps Deployment Tasks for Azure Data Factory objects
MIT License
39 stars 21 forks source link

Connection String elements on config files parsed incorrectly #79

Closed cosmic-jester-uk closed 2 years ago

cosmic-jester-uk commented 2 years ago

Publish Azure Data Factory - is adding extra chars onto connection strings when parsing the config file. Example: "Integrated Security" becomes "integrated security". It always seems to be the same char that gets added. I have checked the strings for unprintable unicode chars and there are none present. Obviously this breaks the deployment as the linked services will not work until manually corrected after release.

As the incorrectly parsed string doesn't fit into any of the input boxes, it adds them as "Additional Connection Properties". image

NowinskiK commented 2 years ago

Please double-check whether your config file is saved with UTF-8 encoding.

cosmic-jester-uk commented 2 years ago

Hi Kamil, I tried it both ways and still the same issue. Which is the correct way? Cheers, Dave

Sent from my iPhone

On 21 Dec 2021, at 12:35, Kamil Nowinski @.***> wrote:



Please double-check whether your config file is saved with UTF-8 encoding.

— Reply to this email directly, view it on GitHubhttps://github.com/SQLPlayer/azure.datafactory.devops/issues/79#issuecomment-998743632, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AW7UOXFJL2PMWICYHC6MJD3USBYCXANCNFSM5KNQU5DQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.***>

cosmic-jester-uk commented 2 years ago

Hi just to update this one. The extra chars have stopped appearing now I stopped using UTF-8 encoding on csv file. The values still aren’t aren’t landing in the correct fields and are dropping into additional connection properties. It’s only on SQL server Type linked services and only on the connection string. Cheers, Dave

Sent from my iPhone

On 21 Dec 2021, at 13:47, David Edmonds @.***> wrote:

 Hi Kamil, I tried it both ways and still the same issue. Which is the correct way? Cheers, Dave

Sent from my iPhone

On 21 Dec 2021, at 12:35, Kamil Nowinski @.***> wrote:



Please double-check whether your config file is saved with UTF-8 encoding.

— Reply to this email directly, view it on GitHubhttps://github.com/SQLPlayer/azure.datafactory.devops/issues/79#issuecomment-998743632, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AW7UOXFJL2PMWICYHC6MJD3USBYCXANCNFSM5KNQU5DQ. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you authored the thread.Message ID: @.***>

NowinskiK commented 2 years ago

Please attach at least two files: config files and Linked Service causes the problem.

cosmic-jester-uk commented 2 years ago

Config-UAT.csv onpremiseSQLServer.txt Here you go. I have removed sensitive info from connection strings but the format is identical.

NowinskiK commented 2 years ago

Try to reproduce this issue on your local PC with PS module first. You should be able to check substituted values in new file ~onpremiseSQLServer.txt

NowinskiK commented 2 years ago

Also, try to encapsulate values (in CSV config file) in quotes: image

cosmic-jester-uk commented 2 years ago

Ok I will give it a try, I didn't use quotes for somethings as I copied them out of the JSON view of the LS and noticed that only some things had quotes. Thanks for the help

cosmic-jester-uk commented 2 years ago

Double quotes around the values has fixed it. Many Many thanks for the great product and excellent speedy assistance. Best Wishes and Happy Christmas, Dave

NowinskiK commented 2 years ago

Thanks. The same to you!