Azure-Player / azure.datafactory.devops

Azure DevOps Deployment Tasks for Azure Data Factory objects
MIT License
39 stars 21 forks source link

Object Filtering: Includes override excludes #82

Closed ihor-z-i closed 2 years ago

ihor-z-i commented 2 years ago

When filtering configuration provides both: include and exclude rules then include rules override exclude

Looking at the code in the scipt if there are any include rules the code will reset ToBeDeployed value to false which means that any marks that were done in the previous exclude loop is lost.

That means that configuration allows to use either exclude rules or include. If that is an intended behavior it needs to be mentioned in the documentation.

If that is not intended then maybe the code can be changed to loop through all objects and call IsNameExcluded method which seem to check both rules.

NowinskiK commented 2 years ago

This is intended behaviour and appears in documentation.

Bear in mind that Includes and Excludes lists are rules out each other.
Objects would be excluded from deployment only if Includes list remains empty.
When both lists are empty - all objects going to be published.

Link: https://github.com/SQLPlayer/azure.datafactory.tools/blob/master/README.md