Azure-Player / azure.datafactory.tools

Tools for deploying Data Factory (v2) in Microsoft Azure
https://azureplayer.net/adftools
MIT License
217 stars 69 forks source link

ADFT0022: Type [managedVirtualNetwork\default\managedPrivateEndpoint] is not supported #140

Closed rdurham285 closed 3 years ago

rdurham285 commented 3 years ago

Trying to add configurations for managed Private Endpoints.

Test-AdfCode -RootFolder .\

Yields this output

IntegrationRuntimes: 0 object(s) loaded.
LinkedServices: 0 object(s) loaded.
Pipelines: 0 object(s) loaded.
DataSets: 0 object(s) loaded.
DataFlows: 0 object(s) loaded.
Triggers: 0 object(s) loaded.
Managed VNet: 1 object(s) loaded.
Managed Private Endpoints: 1 object(s) loaded.
Factories: 1 object(s) loaded.
=== Validating files ...
Checking: [factory].[FC-AZ-DF-USC-Dev-ADF]...
Checking: [managedVirtualNetwork].[default]...
Checking: [managedVirtualNetwork\default\managedPrivateEndpoint].[TEST_THE_BLOB_Endpoint]...
=== Validating other rules ...
=== Validating config files ...
Config file:   C:\Users\rldurham\Documents\Repos\data.etl.adf\deployment\config-dev.csv
ERROR: ADFT0022: Config file, row 1 : Type (managedVirtualNetwork\default\managedPrivateEndpoint) is not supported.

I am able to reproduce this with my code base - I looked at the test referenced test case in this issue and noticed this test case has the config commented out. I was able to reproduce when un-commenting out that config. https://github.com/SQLPlayer/azure.datafactory.tools/blob/master/test/BigFactorySample2_vnet/deployment/config-endpoint.csv

My private endpoint

{
    "name": "TEST_THE_BLOB_Endpoint",
    "properties": {
        "privateLinkResourceId": "OMITTED",
        "groupId": "table"
    }
}

My config

type,name,path,value
managedVirtualNetwork\default\managedPrivateEndpoint,TEST_THE_BLOB_Endpoint,$.properties.groupId,"table"
NowinskiK commented 3 years ago

hey @rdurham285, I checked the configuration file in the example you mentioned, and in fact, the first line is commented out, but the second should works. Did you check it out?

type,name,path,value
managedPrivateEndpoint,TEST_THE_BLOB_Endpoint,$.properties.groupId,"table"
rdurham285 commented 3 years ago

I did yes. I double checked just now as well. Same result.

image

NowinskiK commented 3 years ago

For some reason you still have a long-version of type: managedVirtualNetwork\default\managedPrivateEndpoint in your config file. Otherwise, the error message would be different. Type in the error message comes directly from the config file.

rdurham285 commented 3 years ago

I misread your last message. Thank you. That works.