Azure-Player / azure.datafactory.tools

Tools for deploying Data Factory (v2) in Microsoft Azure
https://azureplayer.net/adftools
MIT License
207 stars 69 forks source link

Git integration being removed in ADF when using PublishADFTask #342

Closed martin-villalba closed 1 year ago

martin-villalba commented 1 year ago

We have an ADF with Git Integration enabled and would like to publish the changes in ADF every time a PR is merged to our Dev branch. The publishing seems to work, but after the deployment stage, the Git Integration is gone. Is this supposed to happen? We have a separate deployment POC using Git Enterprise and it does not happen in there.

This is the task we configured: image

martin-villalba commented 1 year ago

When I re-enable Git Integration, if I choose to save the current changes to a branch, it generates some differences with what we have in our repo:

image

Are those differences somehow making ADF to disable the Git Integration?

NowinskiK commented 1 year ago

AFAIK these were optional, but sometimes are being added to the code by ADF backend when saving objects. Definitely not a culprit of switching off GIT integration.

martin-villalba commented 1 year ago

Performing additional tests I'm having a scenario where if I add Global Parameters to the ADF instance, the publish removes the Git Integration and if I remove the Global Parameters, the publish does not remove the Git Integration.

NowinskiK commented 1 year ago

Hopefully I will be able to check that this week.

NowinskiK commented 1 year ago

Related to: #241

NowinskiK commented 1 year ago

I tried to reproduce the issue, but I can't. Please provide a script with all required file to reproduce the issue, so then I can reopen this ticket.