Azure-Player / azure.synapse.tools

PowerShell module to deploy Synapse workspace (and more) in Microsoft Azure.
MIT License
20 stars 8 forks source link

Add incremental deployment. #31

Closed LiquoriChris closed 5 months ago

NowinskiK commented 6 months ago

Hi @LiquoriChris , thanks for doing this. Much appreciate. Would you be able to add: 1) Documentation about this feature in README file 2) Unit test for this feature I'm also happy if you want to contribute more to this project and make it more useful, having code & feature-parity with adftools (azure.datafactory.tools) wherever possible.

LiquoriChris commented 6 months ago

Hi @LiquoriChris , thanks for doing this. Much appreciate. Would you be able to add:

  1. Documentation about this feature in README file
  2. Unit test for this feature I'm also happy if you want to contribute more to this project and make it more useful, having code & feature-parity with adftools (azure.datafactory.tools) wherever possible.

Hey @NowinskiK

I have added tests and updated the readme. Please take a look and let me know if anything is needed. Thanks!

LiquoriChris commented 6 months ago

@NowinskiK I made some adjustment on how I get the storage account name from the deployment state class instead using $targetsynapse.

LiquoriChris commented 5 months ago

@NowinskiK I made some adjustment on how I get the storage account name from the deployment state class instead using $targetsynapse.

@NowinskiK please kindly review.

NowinskiK commented 5 months ago

Yes, I will do. I remember about this PR, but I'm a bit busy right now.

NowinskiK commented 5 months ago

Thank you @LiquoriChris for your patience and contribution!