search

Azure-Samples / Azure-Functions-OpenAI-Demo

This C# demo is based on azure-search-openai-demo and uses a static web app for the frontend and Azure functions for the backend API's. This solution uses the Azure Functions OpenAI triggers and binding extension for the backend capabilities.
MIT License
15 stars 10 forks source link

Readme update to simplify azd deployment #9

Closed paulyuk closed 3 months ago

paulyuk commented 3 months ago

Purpose

This is mostly a readme change to simplify the steps to deploy using AZD and reduce dependencies.

Additionally a small section is added to show how to run the apps locally (with remote AI resources).

Last, a few changes to the AZD bicep files were made to improve least permission grant in RBAC for each resource.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

How to Test

What to Check

Verify that the following are valid

paulyuk commented 3 months ago

/assign @eamonoreilly

paulyuk commented 3 months ago

Note this issue is getting in the way of clean checks and is independent of this PR: https://github.com/Azure-Samples/Azure-Functions-OpenAI-Demo/issues/10

@eamonoreilly

paulyuk commented 3 months ago

@eamonoreilly note a few issues/discrepancies with app settings made by Bicep vs. what's documented for AZD. Key names for things like CHAT_MODEL_DEPLOYMENT_NAME do not match. Also the value for OpenAiStorageConnection is set to a full connection string secret, and I think we want it instead to be a OpenAiStorageConnection__accountName.

Would like to consult quickly on what we standardize on.

paulyuk commented 3 months ago

All manual tests pass. Readme updated.

Ready to merge. @eamonoreilly