Azure-Samples / Cognitive-Services-Voice-Assistant

Welcome to the Microsoft Voice Assistant samples repository! Here you will find samples to help you get started building client application for your bot or Custom Command service. You will also be able to easily deploy a working Custom Command based Voice Assistant to your own Azure subscription
MIT License
101 stars 99 forks source link

App crashes when tablet rotates viewing settings menu #388

Closed olmidy closed 4 years ago

olmidy commented 4 years ago

This issue is for a: (mark with an x)

- [x ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

Open Virtual Assistant Client, open settings, rotate

Any log messages given by the failure

Caused by: java.lang.NullPointerException: Attempt to write to field 'java.lang.Boolean com.microsoft.bot.builder.solutions.virtualassistant.utils.AppConfiguration.showFullConversation' on a null object reference

Expected/desired behavior

Don't crash

OS and Version?

Android

Versions

Mention any other details that might be useful


Thanks! We'll be in touch soon.

olmidy commented 4 years ago

PR: https://github.com/microsoft/botframework-solutions/pull/3398