search

Azure-Samples / DoubleKeyEncryptionService

Download, install, and set up the Double Key Encryption service for Microsoft 365.
MIT License
12 stars 14 forks source link

Deploying to production - What should be injected for ippw.IKeyStore #26

Open IshamMohamed opened 3 years ago

IshamMohamed commented 3 years ago

The below lines are mentioned at the Startup.cs 

     #if USE_TEST_KEYS
     #error !!!!!!!!!!!!!!!!!!!!!! Use of test keys is only supported for testing,
     DO NOT USE FOR PRODUCTION !!!!!!!!!!!!!!!!!!!!!!!!!!!!!
     services.AddSingleton<ippw.IKeyStore, ippw.TestKeyStore>();
     #endif

And we just remove those lines except services.AddSingleton<ippw.IKeyStore, ippw.TestKeyStore>(); to test this out. Now to deploy to production, Should we implement our own keystore class which takes the private key from a keyvault with the current setup or what is the production deployment recommendation?

osa2unx commented 3 years ago

I have the exact same question. Deployment of dke via doc.microsoft.com all working. But I want to use the solution in production. What needs to be changed? Any suggestions or is testkey also safe to use?