search

Azure-Samples / MqttApplicationSamples

Samples implementing common PubSub patterns for Edge and Cloud Brokers
MIT License
25 stars 25 forks source link

Hostname HTTP vs. MQTT #60

Closed sseiber closed 1 year ago

sseiber commented 1 year ago

This issue is for a: (mark with an x)

- [ ] bug report -> please search issues before submitting
- [ ] feature request
- [X] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

The setup steps in the Getting Started section use an environment variable named "host_name". For those used to the Azure Portal and may be following along, it might be confusing since there are two hostnames in the EventGrid namespace - one for http and one for mqtt. image

Expected/desired behavior

This environment variable could be called mqtt_hostname to avoid any confusion.

rido-min commented 1 year ago

I'm not following

the envvar is called MQTT_HOST_NAME, it's populated from a local variable called host_name.

host_name=$(az resource show --ids $res_id --query "properties.topicSpacesConfiguration.hostname" -o tsv)

note: that the name of the local variable matches the property name

I will consider the local variable as an implementation detail and I dont think it will confuse customers