search

Azure-Samples / MqttApplicationSamples

Samples implementing common PubSub patterns for Edge and Cloud Brokers
MIT License
25 stars 25 forks source link

Sample with JWT #68

Open patilsnr opened 1 year ago

patilsnr commented 1 year ago

Adds sample with JWT authentication tied to a managed identity

patilsnr commented 1 year ago

/azp run

andyk-ms commented 1 year ago

Please note additional improvements in the PBI as TODO.

rido-min commented 1 year ago

I'd like to do a quick test pass with the new builtin roles before merging.

varunpuranik commented 11 months ago

I'd like to include JWT support in the MqttConnectionSettings, at least we should use .env files to specify the hostname

My machine takes 5+ secs to acquire the token, there might be some optimizations we can make, and also test with a ManagedIdentity

Review how to refresh the token

Let's wait until we have the builtin roles

Do we need to block on this? In the spirit of iterative improvements on these samples, i would suggest we check it in, and put another item on our backlog to improve it based on the steps above. Any concerns @rido-min ? Thoughts @patilsnr ?

patilsnr commented 11 months ago

I'd like to include JWT support in the MqttConnectionSettings, at least we should use .env files to specify the hostname My machine takes 5+ secs to acquire the token, there might be some optimizations we can make, and also test with a ManagedIdentity Review how to refresh the token Let's wait until we have the builtin roles

Do we need to block on this? In the spirit of iterative improvements on these samples, i would suggest we check it in, and put another item on our backlog to improve it based on the steps above. Any concerns @rido-min ? Thoughts @patilsnr ?

I'm pro merging it in, and have been for some time. There are readme instructions on how to use this -- the main improvement to be had is using the built-in roles that have been recently rolled out but don't currently work (as opposed to creating a custom role).

rido-min commented 11 months ago

this PR is blocked by https://github.com/dotnet/MQTTnet/issues/1881