Fix CreateFromEnvVars to allow '=' in env var value.

briancr-ms commented 7 months ago

Purpose

Fix issue #95. Read environment variables that contain an '=' in the value.

Checklist

[x] I have read the contribution guidelines.
I submitted this PR against the correct branch:
- [x] This pull-request is submitted against the main branch.
- [ ] I have merged the latest main branch prior to submission and re-merged as needed after I took any feedback.
- [ ] I will squashed my changes into one with a clear description of the change when I complete the PR.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Run MqttConnectionSettings unit tests.

rido-min commented 7 months ago

we need similar changes to all other languages

briancr-ms commented 7 months ago

we need similar changes to all other languages

That's reasonable. What's the process for this repo? Do all language changes go into the same PR? Or should I create an issue for each language and resolve these through different PRs?

rido-min commented 7 months ago

we are updating each sample in different PRs, before creating issues to track I'd like to understand the request. (keep in mind these are regular .env files)

Azure-Samples / MqttApplicationSamples