search

Azure-Samples / Synapse

Samples for Azure Synapse Analytics
MIT License
378 stars 350 forks source link

File Format "NativeParquet" is never used in SampleDB.sql #28

Open casperlehmann opened 4 years ago

casperlehmann commented 4 years ago

NativeParquet is implemented as a file format, but when the view parquet.YellowTaxi is created, it refers to FORMAT='PARQUET'.

There does not seem to be a reason for it to exist, and it confuses the reader, when they are trying to get up to speed with using the platform. Is there any benefit to creating a custom file format rather than refering to 'PARQUET'?

asears commented 4 years ago

External File Format is required with an External Table, though it is not used in this view example. The OpenRowSet syntax uses a built-in formatter.

Agree, it would be beneficial if this example either removed the unused object or better implemented it and identified where to use a view containing OpenRowSet vs. External Table.

Also See: https://docs.microsoft.com/en-us/sql/t-sql/statements/create-external-table-transact-sql?view=sql-server-ver15 https://docs.microsoft.com/en-us/azure/synapse-analytics/sql/develop-openrowset

casperlehmann commented 4 years ago

Could the NativeParquet custom file format simply be used in one of the examples to make its use more apparent?