search

Azure-Samples / aci-logicapps-integration

Learn how to use Azure Container Instances with Logic Apps to deploy containers in an event-driven way.
MIT License
43 stars 7 forks source link

Samples documentation issue #5

Closed ryancrawcour closed 4 years ago

ryancrawcour commented 6 years ago

the rendered published document found on https://azure.microsoft.com/en-us/resources/samples/aci-logicapps-integration/ does not render correctly. the images do not show properly, nor do any of the tables.

reading directly in GitHub readme.md renders ok though.

mmacy commented 6 years ago

@jluk Do you know who's on the hook for maintaining these sample repos, by chance?

jluk commented 6 years ago

The vendors helped start it, but they are no longer here so I guess that falls on myself. ACOM doesn't have any documentation to my knowledge on what markdown works and what doesn't - making it really difficult to make sure it renders right everywhere.

@mmacy do you know of a doc like that, I'll have to just remove the table if it is not supported by ACOM.

mmacy commented 6 years ago

@jluk The doc in the contributor's guide mentions nothing about Markdown support, so I'll pose a question to the internal team. Will let you know.

jluk commented 6 years ago

Adding @rbitia since she worked with the vendors on this example too, perhaps she can help in upkeep.

mmacy commented 6 years ago

@ryancrawcour Thanks for the report. I've filed a bug for this issue in ACOM's tracker, will update here as I receive updates.

mmacy commented 4 years ago

@ryancrawcour Late follow-up here, but the Azure Samples Browser has been updated significantly since this issue was opened, and images and tables are now rendered as expected. Here's this sample on the new Samples Browser:

https://docs.microsoft.com/samples/azure-samples/aci-logicapps-integration/aci-logicapps-integration/

Closing this one out - thanks again for the report.